Add extra information for ReadingList ContentSuggestion

components/ntp_snippets/content_suggestion.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTION_H_
 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTION_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 28 matching lines @@
 };
 
 // Contains additional data which is only available for recent tab suggestions.
 struct RecentTabSuggestionExtra {
   // Corresponding tab identifier.
   int tab_id;
   // Underlying offline page identifier.
   int64_t offline_page_id = 0;
 };
 
+// ReadingListSuggestionExtra contains additional data which is only available
+// for Reading List suggestions.
+struct ReadingListSuggestionExtra {
+  // State of the distillation a suggestion. This is a duplicate of
+  // ReadingListEntry::DistillationState and should be kept sync. It is
+  // duplicated here to prevent a dependence on ReadingList.

[Olivier, 2017/03/30 08:51:11]

nit s/prevent/avoid/ ?

[gambard, 2017/03/30 08:59:09]

Done.

+  enum class ReadingListSuggestionDistilledState {
+    PROCESSING,

[Olivier, 2017/03/30 08:51:11]

The enums are not synced at the moment. can you comment and/or add missing
states?

[gambard, 2017/03/30 08:59:09]

Done.

+    SUCCESS,
+    FAILURE
+  };
+
+  // State of the distillation of the suggestion.
+  ReadingListSuggestionDistilledState distilled_state =
+      ReadingListSuggestionDistilledState::PROCESSING;
+  // URL of the page whose favicon should be displayed for this suggestion.
+  GURL favicon_page_url;
+};
+
 // Contains additional data for notification-worthy suggestions.
 struct NotificationExtra {
   // Deadline for showing notification. If the deadline is past, the
   // notification is no longer fresh and no notification should be sent. If the
   // deadline passes while a notification is up, it should be canceled.
   base::Time deadline;
 };
 
 // A content suggestion for the new tab page, which can be an article or an
 // offline page, for example.
@@ skipping 78 matching lines @@
       std::unique_ptr<DownloadSuggestionExtra> download_suggestion_extra);
 
   // Extra information for recent tab suggestions. Only available for
   // KnownCategories::RECENT_TABS suggestions.
   RecentTabSuggestionExtra* recent_tab_suggestion_extra() const {
     return recent_tab_suggestion_extra_.get();
   }
   void set_recent_tab_suggestion_extra(
       std::unique_ptr<RecentTabSuggestionExtra> recent_tab_suggestion_extra);
 
+  // Extra information for reading list suggestions. Only available for
+  // KnownCategories::READING_LIST suggestions.
+  ReadingListSuggestionExtra* reading_list_suggestion_extra() const {
+    return reading_list_suggestion_extra_.get();
+  }
+  void set_reading_list_suggestion_extra(
+      std::unique_ptr<ReadingListSuggestionExtra>
+          reading_list_suggestion_extra);
+
   // Extra information for notifications. When absent, no notification should be
   // sent for this suggestion. When present, a notification should be sent,
   // unless other factors disallow it (examples: the extra parameters say to;
   // notifications are disabled; Chrome is in the foreground).
   NotificationExtra* notification_extra() const {
     return notification_extra_.get();
   }
   void set_notification_extra(
       std::unique_ptr<NotificationExtra> notification_extra);
 
   const base::Time& fetch_date() const { return fetch_date_; }
   void set_fetch_date(const base::Time& fetch_date) {
     fetch_date_ = fetch_date;
   }
 
  private:
   ID id_;
   GURL url_;
   base::string16 title_;
   base::string16 snippet_text_;
   base::Time publish_date_;
   base::string16 publisher_name_;
   float score_;
   std::unique_ptr<DownloadSuggestionExtra> download_suggestion_extra_;
   std::unique_ptr<RecentTabSuggestionExtra> recent_tab_suggestion_extra_;
+  std::unique_ptr<ReadingListSuggestionExtra> reading_list_suggestion_extra_;
   std::unique_ptr<NotificationExtra> notification_extra_;
 
   // The time when the remote suggestion was fetched from the server. This field
   // is only populated when the ContentSuggestion is created from a
   // RemoteSuggestion.
   base::Time fetch_date_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSuggestion);
 };
 
 std::ostream& operator<<(std::ostream& os, const ContentSuggestion::ID& id);
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTION_H_