Add extra information for ReadingList ContentSuggestion

components/ntp_snippets/reading_list/reading_list_distillation_state_util.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/ntp_snippets/reading_list/reading_list_distillation_state_util.h"
+
+namespace ntp_snippets {
+
+ReadingListEntry::DistillationState ReadingListStateFromSuggestionState(
+    ReadingListSuggestionExtra::ReadingListSuggestionDistilledState
+        distilled_state) {
+  switch (distilled_state) {
+    case ReadingListSuggestionExtra::ReadingListSuggestionDistilledState::
+        PROCESSING:
+      return ReadingListEntry::PROCESSING;
+      break;

[Marc Treib, 2017/03/29 08:24:58]

No "break" required after "return"

[gambard, 2017/03/29 09:54:07]

Done.

+    case ReadingListSuggestionExtra::ReadingListSuggestionDistilledState::
+        SUCCESS:
+      return ReadingListEntry::PROCESSED;
+      break;
+    case ReadingListSuggestionExtra::ReadingListSuggestionDistilledState::
+        FAILURE:
+      return ReadingListEntry::DISTILLATION_ERROR;
+      break;
+  }
+}

[Marc Treib, 2017/03/29 08:24:58]

I think some compilers (Windows?) will force you to add a dummy return here. In
any case, add NOTREACHED()?

[gambard, 2017/03/29 09:54:07]

Done.

+
+ReadingListSuggestionExtra::ReadingListSuggestionDistilledState
+SuggestionStateFromReadingListState(
+    ReadingListEntry::DistillationState distilled_state) {
+  switch (distilled_state) {
+    case ReadingListEntry::WILL_RETRY:
+    case ReadingListEntry::PROCESSING:
+    case ReadingListEntry::WAITING:
+      return ReadingListSuggestionExtra::ReadingListSuggestionDistilledState::
+          PROCESSING;
+      break;
+    case ReadingListEntry::PROCESSED:
+      return ReadingListSuggestionExtra::ReadingListSuggestionDistilledState::
+          SUCCESS;
+      break;
+    case ReadingListEntry::DISTILLATION_ERROR:
+      return ReadingListSuggestionExtra::ReadingListSuggestionDistilledState::
+          FAILURE;
+      break;
+  }

[Marc Treib, 2017/03/29 08:24:58]

Same here: No "break" after "return", and NOTREACHED()

[gambard, 2017/03/29 09:54:07]

Done.

+}
+
+}  // namespace ntp_snippets