Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 278073004: Revert of Unified Gesture Recognizer (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, tdresser+watch_chromium.org, ben+aura_chromium.org, nasko+codewatch_chromium.org, jam, sadrul, darin-cc_chromium.org, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Unified Gesture Recognizer (https://codereview.chromium.org/251543003/) Reason for revert: GestureRecognizerTest is leaking memory. Original issue's description: > Unified Gesture Recognizer > > This adds the unified GR for Aura behind the --use-unified-gesture-detector flag. > > BUG=332418 > TEST=GestureRecognizer/GestureRecognizerTest.* > MotionEventUITest.* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1004 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/event_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/event_switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/events.gyp View 10 chunks +11 lines, -36 lines 0 comments Download
M ui/events/gesture_detection/gesture_config_helper_aura.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M ui/events/gesture_detection/motion_event.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/gestures/gesture_configuration.h View 4 chunks +2 lines, -12 lines 0 comments Download
M ui/events/gestures/gesture_configuration.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/events/gestures/gesture_provider_aura.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/events/gestures/gesture_provider_aura.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 5 chunks +2 lines, -18 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 7 chunks +44 lines, -141 lines 0 comments Download
M ui/events/gestures/gesture_types.h View 1 chunk +1 line, -1 line 0 comments Download
D ui/events/gestures/motion_event_aura.h View 1 chunk +0 lines, -102 lines 0 comments Download
D ui/events/gestures/motion_event_aura.cc View 1 chunk +0 lines, -241 lines 0 comments Download
D ui/events/gestures/motion_event_aura_unittest.cc View 1 chunk +0 lines, -293 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
Created Revert of Unified Gesture Recognizer
6 years, 7 months ago (2014-05-10 02:00:10 UTC) #1
Lei Zhang
See: http://goo.gl/GoMZeq
6 years, 7 months ago (2014-05-10 02:01:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/278073004/1
6 years, 7 months ago (2014-05-10 02:03:03 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 02:03:04 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 02:03:05 UTC) #5
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698