Issue 278073002: Revert of Factor GrTexture into public GrTexture and private GrTextureImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 278073002: Revert of Factor GrTexture into public GrTexture and private GrTextureImpl. (Closed)

Created:
6 years, 7 months ago by bsalomon

Modified:
6 years, 7 months ago

Reviewers:
jvanverth1, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert of Factor GrTexture into public GrTexture and private GrTextureImpl. (https://codereview.chromium.org/275903002/) Reason for revert: Breaks chrome build. Original issue's description: > Factor GrTexture into public GrTexture and private GrTextureImpl. > > Committed: http://code.google.com/p/skia/source/detail?r=14680 TBR=jvanverth@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14681

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -116 lines)			Patch
M	bench/GrResourceCacheBench.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/GrContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/GrTexture.h	View	7 chunks	+86 lines, -88 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	src/gpu/GrTexture.cpp	View	8 chunks	+10 lines, -13 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of Factor GrTexture into public GrTexture and private GrTextureImpl.

6 years, 7 months ago (2014-05-09 18:01:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/278073002/1

6 years, 7 months ago (2014-05-09 18:02:36 UTC) #2

Message was sent while issue was closed.

Change committed as 14681