ios/web/navigation/navigation_manager_impl.mm - Issue 2780703002: Reload with empty navigation manager should not crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/navigation_manager_impl.mm

Issue 2780703002: Reload with empty navigation manager should not crash (Closed)

Patch Set: Change include navigation_manager.h to import Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/navigation_manager_impl.mm

diff --git a/ios/web/navigation/navigation_manager_impl.mm b/ios/web/navigation/navigation_manager_impl.mm

index a059c1d0e3c19f4421442ccc06de66ddcc44dd38..a87b7b08ab0dc9f62d192773682d73d4bd1bef9f 100644

--- a/ios/web/navigation/navigation_manager_impl.mm

+++ b/ios/web/navigation/navigation_manager_impl.mm

@@ -339,6 +339,9 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {

void NavigationManagerImpl::Reload(ReloadType reload_type,

bool check_for_reposts) {

+ if (!GetTransientItem() && !GetPendingItem() && !GetLastCommittedItem())

+ return;

delegate_->Reload();

}