Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5294)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java

Issue 2780693002: [Home] Toolbar shadow v1 (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
index b2d8c807e800c318831cfc2ad14f831abfe9148e..1ccc5771d0fd6b1a7dcb2a1a5b94ba876ec05768 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
@@ -25,7 +25,6 @@ import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewStub;
import android.widget.FrameLayout;
-import android.widget.RelativeLayout;
import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
@@ -55,7 +54,7 @@ import javax.annotation.Nullable;
* @param <E> The type of the selectable items this layout holds.
*/
public class SelectableListLayout<E>
- extends RelativeLayout implements DisplayStyleObserver, SelectionObserver<E> {
+ extends FrameLayout implements DisplayStyleObserver, SelectionObserver<E> {
/**
* @param res Resources used to retrieve drawables and dimensions.
* @return The default list item lateral margin size in pixels. This value should be used in
@@ -318,6 +317,13 @@ public class SelectableListLayout<E>
*/
public Toolbar detachToolbarView() {
removeView(mToolbar);
+
+ // The top margin for the content and shadow needs to be removed now that the toolbar
+ // has been removed.
+ View content = findViewById(R.id.list_content);
+ ((MarginLayoutParams) content.getLayoutParams()).topMargin = 0;
+ ((MarginLayoutParams) mToolbarShadow.getLayoutParams()).topMargin = 0;
+
return mToolbar;
}

Powered by Google App Engine
This is Rietveld 408576698