Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: components/exo/pointer.h

Issue 2780623002: exo: Fix multi-display hardware cursor (Closed)
Patch Set: Fix accessibility test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/pointer.h
diff --git a/components/exo/pointer.h b/components/exo/pointer.h
index 07cf6bdc0260b9a017054d5eb2d746469b135f2e..17091db9a571c5b75a653ff69cd2bd4ab446ce16 100644
--- a/components/exo/pointer.h
+++ b/components/exo/pointer.h
@@ -13,6 +13,7 @@
#include "components/exo/surface_delegate.h"
#include "components/exo/surface_observer.h"
#include "components/exo/wm_helper.h"
+#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/base/cursor/cursor.h"
#include "ui/events/event_constants.h"
#include "ui/events/event_handler.h"
@@ -59,6 +60,7 @@ class Pointer : public ui::EventHandler,
// Overridden from WMHelper::CursorObserver:
void OnCursorSetChanged(ui::CursorSetType cursor_set) override;
+ void OnCursorDisplayChanged(const display::Display& display) override;
// Overridden from SurfaceDelegate:
void OnSurfaceCommit() override;
@@ -71,19 +73,19 @@ class Pointer : public ui::EventHandler,
// Returns the effective target for |event|.
Surface* GetEffectiveTargetForEvent(ui::Event* event) const;
- // Recompute cursor scale and update cursor if scale changed.
- void UpdateCursorScale();
-
// Asynchronously update the cursor by capturing a snapshot of |surface_|.
- void CaptureCursor();
+ void CaptureCursor(const gfx::Point& hotspot);
// Called when cursor snapshot has been captured.
void OnCursorCaptured(const gfx::Point& hotspot,
std::unique_ptr<cc::CopyOutputResult> result);
- // Update cursor to reflect the current value of |cursor_|.
+ // Synchronously update the cursor to the latest snapshot.
reveman 2017/05/31 03:33:10 nit: not sure synchronously needs to be mentioned
Dominik Laskowski 2017/05/31 20:35:55 Done.
void UpdateCursor();
+ // Update cursor to reflect the current value of |cursor_|.
+ void SetCursor();
+
// The delegate instance that all events are dispatched to.
PointerDelegate* const delegate_;
@@ -96,12 +98,12 @@ class Pointer : public ui::EventHandler,
// The location of the pointer in the current focus surface.
gfx::PointF location_;
- // The scale applied to the cursor to compensate for the UI scale.
- float cursor_scale_ = 1.0f;
-
// The position of the pointer surface relative to the pointer location.
gfx::Point hotspot_;
+ // Latest cursor snapshot.
+ SkBitmap cursor_bitmap_;
+
// The current cursor.
ui::Cursor cursor_;

Powered by Google App Engine
This is Rietveld 408576698