Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2780543002: Handle complicated imports. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove debugging code. #

Patch Set 3 : Fix infinite loop. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -95 lines) Patch
M pkg/front_end/lib/src/fasta/builder/builder.dart View 4 chunks +4 lines, -56 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/invalid_type_builder.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/prefix_builder.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/import.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 2 chunks +86 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 2 4 chunks +16 lines, -7 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
ahe
3 years, 9 months ago (2017-03-27 15:44:15 UTC) #3
karlklose
LGTM
3 years, 8 months ago (2017-03-28 06:20:15 UTC) #4
ahe
Thank you, Karl. There was an infinite loop when compiling co19/Language/Libraries_and_Scripts/Imports/namespace_changes_t22. I've fixed that. PTAL.
3 years, 8 months ago (2017-03-28 06:27:48 UTC) #5
karlklose
Still LGTM
3 years, 8 months ago (2017-03-28 06:55:46 UTC) #6
ahe
3 years, 8 months ago (2017-03-29 08:44:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
a49bc6012031922b03d9af855cf4829ea240781b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698