Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 278053002: Move DataTypeManager into sync_driver component (Closed)

Created:
6 years, 7 months ago by Nicolas Zea
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Move DataTypeManager into sync_driver component BUG=339762 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269956

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1940 lines) Patch
D chrome/browser/sync/glue/data_type_manager_impl.h View 1 chunk +0 lines, -194 lines 0 comments Download
D chrome/browser/sync/glue/data_type_manager_impl.cc View 1 chunk +0 lines, -597 lines 0 comments Download
D chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 1 chunk +0 lines, -1122 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/sync_driver/data_type_manager_impl.h View 5 chunks +7 lines, -3 lines 0 comments Download
A + components/sync_driver/data_type_manager_impl.cc View 7 chunks +5 lines, -8 lines 0 comments Download
A + components/sync_driver/data_type_manager_impl_unittest.cc View 1 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nicolas Zea
Went ahead and moved this over to help with my datatype refactoring, PTAL
6 years, 7 months ago (2014-05-09 18:23:59 UTC) #1
tim (not reviewing)
lgtm
6 years, 7 months ago (2014-05-12 17:03:41 UTC) #2
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 7 months ago (2014-05-12 17:36:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/278053002/20001
6 years, 7 months ago (2014-05-12 17:37:26 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 21:12:46 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 01:26:08 UTC) #6
Message was sent while issue was closed.
Change committed as 269956

Powered by Google App Engine
This is Rietveld 408576698