Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2780513004: [Kernel] Remove code from the old type propagation. (Closed)

Created:
3 years, 8 months ago by asgerf
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Kernel] Remove code from the old type propagation. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/a3402df15cd0469d043fc8a25f4e3da28e19e7ba

Patch Set 1 #

Patch Set 2 : Remove empty status file section #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3999 lines) Patch
M pkg/kernel/bin/transform.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/kernel/binary.md View 4 chunks +0 lines, -11 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 10 chunks +0 lines, -12 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 6 chunks +0 lines, -15 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 4 chunks +0 lines, -14 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 4 chunks +1 line, -31 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/converter.dart View 2 chunks +1 line, -4 lines 0 comments Download
D pkg/kernel/lib/transformations/infer_values.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D pkg/kernel/lib/type_propagation/builder.dart View 1 chunk +0 lines, -1984 lines 0 comments Download
D pkg/kernel/lib/type_propagation/canonicalizer.dart View 1 chunk +0 lines, -109 lines 0 comments Download
D pkg/kernel/lib/type_propagation/constraints.dart View 1 chunk +0 lines, -175 lines 0 comments Download
D pkg/kernel/lib/type_propagation/solver.dart View 1 chunk +0 lines, -427 lines 0 comments Download
D pkg/kernel/lib/type_propagation/type_propagation.dart View 1 chunk +0 lines, -168 lines 0 comments Download
D pkg/kernel/lib/type_propagation/visualizer.dart View 1 chunk +0 lines, -395 lines 0 comments Download
M pkg/kernel/lib/visitor.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D pkg/kernel/test/baseline_type_propagation_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D pkg/kernel/test/type_propagation_dump.dart View 1 chunk +0 lines, -188 lines 0 comments Download
D pkg/kernel/test/type_propagation_selfcheck.dart View 1 chunk +0 lines, -183 lines 0 comments Download
D pkg/kernel/test/uint31_pair_map_bench.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D pkg/kernel/test/uint31_pair_map_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
M pkg/pkg.status View 1 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/kernel.h View 9 chunks +0 lines, -63 lines 0 comments Download
M runtime/vm/kernel.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 4 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 8 months ago (2017-03-28 08:17:58 UTC) #2
Kevin Millikin (Google)
LGTM.
3 years, 8 months ago (2017-03-28 10:24:01 UTC) #3
asgerf
3 years, 8 months ago (2017-03-28 10:43:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a3402df15cd0469d043fc8a25f4e3da28e19e7ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698