Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: components/printing/renderer/print_web_view_helper.h

Issue 2780433002: add print to pdf for headless (Closed)
Patch Set: improve comments as suggested Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/printing/renderer/print_web_view_helper.h
diff --git a/components/printing/renderer/print_web_view_helper.h b/components/printing/renderer/print_web_view_helper.h
index d979333feb1fd72972fe4109e1afc061f49af2d1..6702ef3fa504878500a2c6dc4159079e86d461bb 100644
--- a/components/printing/renderer/print_web_view_helper.h
+++ b/components/printing/renderer/print_web_view_helper.h
@@ -108,6 +108,15 @@ class PrintWebViewHelper
// Returns true if printing is overridden and the default behavior should be
// skipped for |frame|.
virtual bool OverridePrint(blink::WebLocalFrame* frame) = 0;
+
+#if defined(OS_MACOSX)
+ // If true, all the printed pages are returned in the first
+ // PrintHostMsg_DidPrintPage metafile, like on Linux and Windows.
+ // NOTE: PrintHostMsg_DidPrintPage messages for all pages contain the same
+ // page and content area, which may lead to bug when these two parameters
+ // are different per page.
+ virtual bool UseSingleMetafile();
+#endif
};
PrintWebViewHelper(content::RenderFrame* render_frame,
@@ -283,8 +292,9 @@ class PrintWebViewHelper
// Prints the page listed in |params|.
#if defined(OS_MACOSX)
- void PrintPageInternal(const PrintMsg_PrintPage_Params& params,
- blink::WebLocalFrame* frame);
+ void PrintPagesInternal(const PrintMsg_PrintPage_Params& params,
+ blink::WebLocalFrame* frame,
+ const std::vector<int>& printed_pages);
#else
void PrintPageInternal(const PrintMsg_PrintPage_Params& params,
blink::WebLocalFrame* frame,

Powered by Google App Engine
This is Rietveld 408576698