Index: headless/lib/browser/headless_devtools_manager_delegate.h |
diff --git a/headless/lib/browser/headless_devtools_manager_delegate.h b/headless/lib/browser/headless_devtools_manager_delegate.h |
index 29c8c1d870d3b6235e64edac47a711f7dc0c7156..0bf6937055bad9d6e9a14938d70c66eb207ff857 100644 |
--- a/headless/lib/browser/headless_devtools_manager_delegate.h |
+++ b/headless/lib/browser/headless_devtools_manager_delegate.h |
@@ -5,14 +5,13 @@ |
#ifndef HEADLESS_LIB_BROWSER_HEADLESS_DEVTOOLS_MANAGER_DELEGATE_H_ |
#define HEADLESS_LIB_BROWSER_HEADLESS_DEVTOOLS_MANAGER_DELEGATE_H_ |
-#include "content/public/browser/devtools_manager_delegate.h" |
- |
#include <map> |
#include <memory> |
#include <string> |
#include "base/memory/weak_ptr.h" |
#include "base/values.h" |
+#include "content/public/browser/devtools_manager_delegate.h" |
namespace headless { |
class HeadlessBrowserImpl; |
@@ -27,6 +26,9 @@ class HeadlessDevToolsManagerDelegate |
// DevToolsManagerDelegate implementation: |
base::DictionaryValue* HandleCommand(content::DevToolsAgentHost* agent_host, |
base::DictionaryValue* command) override; |
+ bool HandleAsyncCommand(content::DevToolsAgentHost* agent_host, |
+ base::DictionaryValue* command, |
+ CommandCallback callback) override; |
Lei Zhang
2017/03/29 01:38:03
Pass by const-ref. You need to fix content/public/
jzfeng
2017/03/29 03:50:13
Done. So whenever I want to pass a callback, it sh
Eric Seckler
2017/03/29 11:21:19
Yeah, usually :)
|
scoped_refptr<content::DevToolsAgentHost> CreateNewTarget( |
const GURL& url) override; |
std::string GetDiscoveryPageHTML() override; |
@@ -45,6 +47,10 @@ class HeadlessDevToolsManagerDelegate |
std::unique_ptr<base::DictionaryValue> DisposeBrowserContext( |
int command_id, |
const base::DictionaryValue* params); |
+ void PrintToPDF(content::DevToolsAgentHost* agent_host, |
+ int command_id, |
+ const base::DictionaryValue* params, |
+ CommandCallback callback); |
base::WeakPtr<HeadlessBrowserImpl> browser_; |
@@ -53,6 +59,14 @@ class HeadlessDevToolsManagerDelegate |
const base::DictionaryValue* params); |
std::map<std::string, CommandMemberFnPtr> command_map_; |
+ |
+ using AsyncCommandMemberFnPtr = void (HeadlessDevToolsManagerDelegate::*)( |
Lei Zhang
2017/03/29 01:38:03
I asked on https://codereview.chromium.org/2119063
jzfeng
2017/03/29 03:50:13
Sounds good. Maybe Eric can also answer this quest
Eric Seckler
2017/03/29 11:21:19
Yeah, sounds like you came to a conclusion in the
|
+ content::DevToolsAgentHost* agent_host, |
+ int command_id, |
+ const base::DictionaryValue* params, |
+ CommandCallback callback); |
+ |
+ std::map<std::string, AsyncCommandMemberFnPtr> async_command_map_; |
}; |
} // namespace headless |