Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2780403003: Removed -[CRWWebDelegate webWillInitiateLoadWithParams:]. (Closed)
Patch Set: Addressed review comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index 30b394fe6b6ed0095dd9fd0d6a102d1c03bac64b..6f4d5698401f9bdf175eee164c768043f12512dc 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1062,28 +1062,22 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
addPageVector_.clear();
}
-- (void)webWillInitiateLoadWithParams:
- (web::NavigationManager::WebLoadParams&)params {
- GURL navUrl = params.url;
-
+- (void)webDidUpdateSessionForLoadWithParams:
+ (const web::NavigationManager::WebLoadParams&)params
+ wasInitialNavigation:(BOOL)initialNavigation {
// After a crash the NTP is loaded by default.
- if (navUrl.host() != kChromeUINewTabHost) {
+ if (params.url.host() != kChromeUINewTabHost) {
static BOOL hasLoadedPage = NO;
if (!hasLoadedPage) {
- // As soon as an URL is loaded, a crash shouldn't be counted as a startup
- // crash. Since loading an url requires user action and is a significant
- // source of crashes that could lead to false positives in crash loop
- // detection.
+ // As soon as load is initialted, a crash shouldn't be counted as a
+ // startup crash. Since initiating a url load requires user action and is
+ // a significant source of crashes that could lead to false positives in
+ // crash loop detection.
crash_util::ResetFailedStartupAttemptCount();
hasLoadedPage = YES;
}
}
-}
-- (void)webDidUpdateSessionForLoadWithParams:
- (const web::NavigationManager::WebLoadParams&)params
- wasInitialNavigation:(BOOL)initialNavigation {
- GURL navUrl = params.url;
ui::PageTransition transition = params.transition_type;
// Record any explicit, non-redirect navigation as a clobber (as long as it's
« no previous file with comments | « no previous file | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698