chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java - Issue 2780403002: WebView: change default shouldOverrideUrlLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java

Issue 2780403002: WebView: change default shouldOverrideUrlLoading (Closed)

Patch Set: Squash commits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java

index 0a7aece838e4fc8595068c44d1e48cc251350523..4d616f5cb045f055e8aa00cdadef296dabd2f9da 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java

@@ -35,6 +35,7 @@ import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.document.ActivityDelegate;

import org.chromium.chrome.browser.util.IntentUtils;

import org.chromium.content_public.browser.LoadUrlParams;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.content_public.common.Referrer;

import org.chromium.ui.base.PageTransition;

@@ -695,12 +696,12 @@ public class IntentHandler {

String lowerCaseScheme = scheme.toLowerCase(Locale.US);

if (UrlConstants.CHROME_SCHEME.equals(lowerCaseScheme)

|| UrlConstants.CHROME_NATIVE_SCHEME.equals(lowerCaseScheme)

- || UrlConstants.ABOUT_SCHEME.equals(lowerCaseScheme)) {

+ || ContentUrlConstants.ABOUT_SCHEME.equals(lowerCaseScheme)) {

// Allow certain "safe" internal URLs to be launched by external

// applications.

String lowerCaseUrl = url.toLowerCase(Locale.US);

- if (UrlConstants.ABOUT_BLANK_DISPLAY_URL.equals(lowerCaseUrl)

- || UrlConstants.ABOUT_BLANK_URL.equals(lowerCaseUrl)) {

+ if (ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL.equals(lowerCaseUrl)

+ || ContentUrlConstants.ABOUT_BLANK_URL.equals(lowerCaseUrl)) {

return false;

}