Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 2780373002: Use observer pattern instead of sniffing SwapCompositorFrame IPC (Closed)
Patch Set: Addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc
diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc
index 486ff56289938f99b4ff258bc975137c64644504..b788af9b4b0d4cbc8131f8c4ffef539534f5337c 100644
--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc
+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc
@@ -238,8 +238,7 @@ class WebContentsViewAuraTest : public ContentBrowserTest {
screenshot_manager_ = new ScreenshotTracker(controller);
controller->SetScreenshotManager(base::WrapUnique(screenshot_manager_));
- frame_watcher_ = new FrameWatcher();
- frame_watcher_->AttachTo(shell()->web_contents());
+ frame_watcher_.Observe(shell()->web_contents());
}
void SetUpCommandLine(base::CommandLine* cmd) override {
@@ -381,7 +380,7 @@ class WebContentsViewAuraTest : public ContentBrowserTest {
void WaitAFrame() {
while (!GetRenderWidgetHost()->ScheduleComposite())
GiveItSomeTime();
- frame_watcher_->WaitFrames(1);
+ frame_watcher_.WaitFrames(1);
}
protected:
@@ -398,7 +397,7 @@ class WebContentsViewAuraTest : public ContentBrowserTest {
private:
ScreenshotTracker* screenshot_manager_;
scoped_refptr<InputEventMessageFilterWaitsForAcks> filter_;
- scoped_refptr<FrameWatcher> frame_watcher_;
+ FrameWatcher frame_watcher_;
DISALLOW_COPY_AND_ASSIGN(WebContentsViewAuraTest);
};
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698