content/browser/renderer_host/input/composited_scrolling_browsertest.cc - Issue 2780373002: Use observer pattern instead of sniffing SwapCompositorFrame IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/composited_scrolling_browsertest.cc

Issue 2780373002: Use observer pattern instead of sniffing SwapCompositorFrame IPC (Closed)

Patch Set: Addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | content/browser/renderer_host/input/non_blocking_event_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/composited_scrolling_browsertest.cc

diff --git a/content/browser/renderer_host/input/composited_scrolling_browsertest.cc b/content/browser/renderer_host/input/composited_scrolling_browsertest.cc

index 9785958481f741ad70a0fe0d5ce5df03f098ed18..b3fff2e3badb2ce8579e4169512dfed0a9a5f744 100644

--- a/content/browser/renderer_host/input/composited_scrolling_browsertest.cc

+++ b/content/browser/renderer_host/input/composited_scrolling_browsertest.cc

@@ -83,8 +83,7 @@ class CompositedScrollingBrowserTest : public ContentBrowserTest {

NavigateToURL(shell(), data_url);

RenderWidgetHostImpl* host = GetWidgetHost();

- scoped_refptr<FrameWatcher> frame_watcher(new FrameWatcher());

- frame_watcher->AttachTo(shell()->web_contents());

+ FrameWatcher frame_watcher(shell()->web_contents());

host->GetView()->SetSize(gfx::Size(400, 400));

base::string16 ready_title(base::ASCIIToUTF16("ready"));

@@ -95,7 +94,7 @@ class CompositedScrollingBrowserTest : public ContentBrowserTest {

// otherwise the injection of the synthetic gestures may get

// dropped because of MainThread/Impl thread sync of touch event

// regions.

- frame_watcher->WaitFrames(1);

+ frame_watcher.WaitFrames(1);

}

// ContentBrowserTest: