content/browser/devtools/render_frame_devtools_agent_host.h - Issue 2780373002: Use observer pattern instead of sniffing SwapCompositorFrame IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.h

Issue 2780373002: Use observer pattern instead of sniffing SwapCompositorFrame IPC (Closed)

Patch Set: Addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/render_frame_devtools_agent_host.h

diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h

index 399409d64096b3d3a01bca6dd26c60458a089c1d..ff6bbd85a03fa257e5afbc5dcad74e9fa18498e8 100644

--- a/content/browser/devtools/render_frame_devtools_agent_host.h

+++ b/content/browser/devtools/render_frame_devtools_agent_host.h

@@ -117,11 +117,11 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost

void RenderProcessGone(base::TerminationStatus status) override;

bool OnMessageReceived(const IPC::Message& message,

RenderFrameHost* render_frame_host) override;

- bool OnMessageReceived(const IPC::Message& message) override;

void DidAttachInterstitialPage() override;

void DidDetachInterstitialPage() override;

void WasShown() override;

void WasHidden() override;

+ void DidReceiveCompositorFrame() override;

void AboutToNavigateRenderFrame(RenderFrameHost* old_host,

RenderFrameHost* new_host);