Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2780353003: Remove TestMediaStreamVideoRenderer usage from LayoutTests.

Created:
3 years, 8 months ago by Yeol Park
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TestMediaStreamVideoRenderer usage from LayoutTests. When running layout tests, there isn't a real video renderer for media streams but a TestMediaStreamVideoRenderer implementation instead. This implementation generates a stream of white frames and sends them in certain intervals. Video content aren't the real content and video events are also useless. BUG=704302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -179 lines) Patch
M content/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc View 3 chunks +1 line, -28 lines 0 comments Download
D content/shell/renderer/layout_test/test_media_stream_video_renderer.h View 1 chunk +0 lines, -66 lines 0 comments Download
D content/shell/renderer/layout_test/test_media_stream_video_renderer.cc View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 13 (10 generated)
Yeol Park
PTAL :)
3 years, 8 months ago (2017-03-30 02:15:32 UTC) #3
Mike West
The failing layout tests suggest that we still need this. WDYT?
3 years, 8 months ago (2017-03-30 06:31:34 UTC) #12
emircan
3 years, 8 months ago (2017-03-30 17:08:25 UTC) #13
Thanks for your work on this Park. I only opened that bug to understand the
reasons behind this design decision and make a discussion. I am not sure if this
is something we need to change yet. Also, it would require more changes in tests
that rely on the previous behavior as we can see from the failing ones. 

Thanks again for your time, but I would recommend waiting on this. I will ping
the bug to see if there can be progress. In the meantime, I would recommend
looking at issues marked with Hotlist-GoodFirstBug.
https://bugs.chromium.org/p/chromium/issues/list?can=2&q=Hotlist%3DGoodFirstB...

Powered by Google App Engine
This is Rietveld 408576698