LayoutTests/svg/custom/use-modify-target-container.svg - Issue 278033003: Avoid using instanceRoot in layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/use-modify-target-container.svg

Issue 278033003: Avoid using instanceRoot in layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/svg/custom/use-listener-append-crash.html ('k') | LayoutTests/svg/custom/use-modify-target-symbol.svg » ('j') | no next file with comments »

OLD	NEW
1 <?xml version="1.0" standalone="no"?>	1 <?xml version="1.0" standalone="no"?>

2 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1 .1/DTD/svg11.dtd">	2 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1 .1/DTD/svg11.dtd">

3 <svg viewBox="0 0 400 300" version="1.1" xmlns="http://www.w3.org/2000/svg" xmln s:xlink="http://www.w3.org/1999/xlink">	3 <svg viewBox="0 0 400 300" version="1.1" xmlns="http://www.w3.org/2000/svg" xmln s:xlink="http://www.w3.org/1999/xlink">

4 <defs>	4 <defs>

5 <g id="g" transform="translate(0 50)">	5 <g id="g" transform="translate(0 50)">

6 <rect id="rect" stroke-width="5px" fill="red" stroke="navy" width="60" h eight="10"/>	6 <rect id="rect" stroke-width="5px" fill="red" stroke="navy" width="60" h eight="10"/>

7 <circle id="circle" opacity="0.5" fill="green" cx="30" cy="5" r="10"/>	7 <circle id="circle" opacity="0.5" fill="green" cx="30" cy="5" r="10"/>

8 </g>	8 </g>

9 </defs>	9 </defs>

10	10

11 <use x="25" y="25" xlink:href="#g"/>	11 <use x="25" y="25" xlink:href="#g"/>

12 <use x="125" y="25" xlink:href="#g"/>	12 <use x="125" y="25" xlink:href="#g"/>

13	13

14 <text font-size="10" id="text" x="30" y="70">You should shapes _above_ this text </text>	14 <text font-size="10" id="text" x="30" y="70">You should shapes _above_ this text </text>

15	15

16 <script>	16 <script>

17 var useElement = document.getElementsByTagName("use")[1];	17 var useElement = document.getElementsByTagName("use")[1];

18 var element = useElement.instanceRoot.correspondingElement;	18 var element = document.getElementById("g");

19	19

20 element.setAttribute("transform", "");	20 element.setAttribute("transform", "");

21 </script>	21 </script>

22 </svg>	22 </svg>

OLD	NEW