Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 278033003: Avoid using instanceRoot in layout tests (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid using instanceRoot in layout tests Avoid using instanceRoot in layout tests, instead get the correspong element directly by using getElementById. BUG=313438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M LayoutTests/svg/custom/use-listener-append-crash.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/use-modify-target-container.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/use-modify-target-symbol.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/use-on-use-with-child.svg View 1 chunk +9 lines, -5 lines 0 comments Download
M LayoutTests/svg/custom/use-on-use-with-child-expected.txt View 1 chunk +8 lines, -4 lines 0 comments Download
M LayoutTests/svg/dom/use-transform.svg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
PTAL. I am converting these tests as they can't work when instanceRoot is removed but ...
6 years, 7 months ago (2014-05-10 21:29:26 UTC) #1
pdr.
On 2014/05/10 21:29:26, rwlbuis wrote: > PTAL. I am converting these tests as they can't ...
6 years, 7 months ago (2014-05-10 21:31:56 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-05-10 21:39:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/278033003/1
6 years, 7 months ago (2014-05-10 21:39:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 22:23:56 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 23:15:45 UTC) #6
Message was sent while issue was closed.
Change committed as 173827

Powered by Google App Engine
This is Rietveld 408576698