third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp - Issue 2780313002: [WIP] Refactor DocumentMarker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

Issue 2780313002: [WIP] Refactor DocumentMarker (Closed)

Patch Set: Move accessor methods into derived classes Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarker.h ('K') | « third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h ('k') | third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp b/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

index c44accb44cd4d85ba95069af37c3b2bcd4d2f527..8c58cdb8614509dd8eed5cb8d2654f94552b2936 100644

--- a/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

@@ -242,7 +242,7 @@ void SVGInlineTextBox::paintDocumentMarker(GraphicsContext&,

void SVGInlineTextBox::paintTextMatchMarkerForeground(

const PaintInfo& paintInfo,

const LayoutPoint& point,

- const DocumentMarker& marker,

+ const TextMatchMarker& marker,

const ComputedStyle& style,

const Font& font) const {

SVGInlineTextBoxPainter(*this).paintTextMatchMarkerForeground(

@@ -252,7 +252,7 @@ void SVGInlineTextBox::paintTextMatchMarkerForeground(

void SVGInlineTextBox::paintTextMatchMarkerBackground(