third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp - Issue 2780313002: [WIP] Refactor DocumentMarker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp

Issue 2780313002: [WIP] Refactor DocumentMarker (Closed)

Patch Set: Move accessor methods into derived classes Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarker.h ('K') | « third_party/WebKit/Source/core/editing/markers/TextMatchMarker.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineTextBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp

index 6bf395ad1c9f0d3909154a71d4898e42ee72526e..8c533337b6a9bcad89387d4713e0006a3f312675 100644

--- a/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp

@@ -51,7 +51,7 @@ bool TextMatchMarkerList::setTextMatchMarkersActive(unsigned startOffset,

bool docDirty = false;

for (auto it = getPosOfFirstMarkerNotEndingBefore(startOffset);

it != m_markers.end(); ++it) {

- DocumentMarker& marker = **it;

+ TextMatchMarker& marker = toTextMatchMarker(**it);

// Markers are stored in order, so stop if we are now past the specified

// range.

if (marker.startOffset() >= endOffset)