third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListTest.cpp - Issue 2780313002: [WIP] Refactor DocumentMarker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListTest.cpp

Issue 2780313002: [WIP] Refactor DocumentMarker (Closed)

Patch Set: Move accessor methods into derived classes Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarker.h ('K') | « third_party/WebKit/Source/core/editing/markers/SpellCheckMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListTest.cpp b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListTest.cpp

index a665ae0f5015d5293bf2215d1d8312f83aea5ecd..e66c84a4e39324e54a78654c043863bb3216ad8e 100644

--- a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListTest.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListTest.cpp

@@ -4,6 +4,7 @@

#include "core/editing/markers/SpellCheckMarkerList.h"

+#include "core/editing/markers/SpellCheckMarker.h"

#include "platform/heap/Handle.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -15,8 +16,8 @@ class SpellCheckMarkerListTest : public ::testing::Test {

: m_markerList(new SpellCheckMarkerList(DocumentMarker::Spelling)) {}

DocumentMarker* createMarker(unsigned startOffset, unsigned endOffset) {

- return new DocumentMarker(DocumentMarker::Spelling, startOffset, endOffset,

- emptyString);

+ return new SpellCheckMarker(DocumentMarker::Spelling, startOffset,

+ endOffset, emptyString);

}

Persistent<SpellCheckMarkerList> m_markerList;