MD Bookmarks: Implement dialog to add new folders/bookmarks

chrome/browser/resources/md_bookmarks/toolbar.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'bookmarks-toolbar',
 
   behaviors: [
     bookmarks.StoreClient,
   ],
@@ skipping 26 matching lines @@
   /**
    * @param {Event} e
    * @private
    */
   onMenuButtonOpenTap_: function(e) {
     var menu = /** @type {!CrActionMenuElement} */ (this.$.dropdown);
     menu.showAt(/** @type {!Element} */ (e.target));
   },
 
   /** @private */
-  onBulkEditTap_: function() {
-    this.closeDropdownMenu_();
-  },
-
-  /** @private */
   onSortTap_: function() {
     this.closeDropdownMenu_();
   },
 
   /** @private */
   onAddBookmarkTap_: function() {
+    var dialog =
+        /** @type {BookmarksEditDialogElement} */ (this.$.addDialog.get());
+    dialog.showAddDialog(false, assert(this.getState().selectedFolder));
     this.closeDropdownMenu_();
   },
 
+  onAddFolderTap_: function() {
+    var dialog =
+        /** @type {BookmarksEditDialogElement} */ (this.$.addDialog.get());
+    dialog.showAddDialog(true, assert(this.getState().selectedFolder));
+    this.closeDropdownMenu_();
+  },
+
   /** @private */
   onImportTap_: function() {
     chrome.bookmarks.import();
     this.closeDropdownMenu_();
   },
 
   /** @private */
   onExportTap_: function() {
     chrome.bookmarks.export();
     this.closeDropdownMenu_();
@@ skipping 16 matching lines @@
   },
 
   onSidebarWidthChanged_: function() {
     this.style.setProperty('--sidebar-width', this.sidebarWidth);
   },
 
   /** @private */
   onSearchTermChanged_: function() {
     this.searchField.setValue(this.searchTerm_ || '');
   },
+
+  /**
+   * @return {boolean}
+   * @private
+   */
+  isSearchActive_: function() {

[calamity, 2017/04/03 07:20:48]

nit: hasSearchTerm_ perhaps? 'Active' search is a bit ambiguous. I thought it
would be calling bookmarks.util.isShowingSearch()

[tsergeant, 2017/04/04 01:21:08]

Renamed.

The util function didn't exist when I first wrote this. I think that keeping it
implemented this way makes sense, especially since the polymer update is tied to
searchTerm_, but isShowingSearch() looks at selectedFolder at the moment.

+    return !!this.searchTerm_;
+  },
 });