src/objects.cc - Issue 2780173002: [regexp] Add support for dotAll flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2780173002: [regexp] Add support for dotAll flag (Closed)

Patch Set: Reserve enough space for '.' character range Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 7f8a2be0e992be4d2ea213d8a2c135e06bdd21ff..c3c5f191e62b5bbe627a4d9c4211d78572958251 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -16122,6 +16122,13 @@ JSRegExp::Flags RegExpFlagsFromString(Handle<String> flags, bool* success) {

case 'm':

flag = JSRegExp::kMultiline;

break;

+ case 's':

+ if (FLAG_harmony_regexp_dotall) {

+ flag = JSRegExp::kDotAll;

+ } else {

+ return JSRegExp::Flags(0);

+ }

+ break;

case 'u':

flag = JSRegExp::kUnicode;

break;