Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl

Issue 2780093003: V8 bindings gen: Error if OriginTrialEnabled and SecureContext together. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_utilities.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl
diff --git a/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl b/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl
index 6664c77b55a0dc3b6598c5828a451ca6d408004d..fb2521d5b91174ba8b38d0103f4fd2b35659d002 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl
+++ b/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl
@@ -6,11 +6,14 @@
// https://github.com/w3c/ServiceWorker/issues/920
[
OriginTrialEnabled=ServiceWorkerNavigationPreload,
- SecureContext,
Exposed=(Window,Worker),
] interface NavigationPreloadManager {
- [CallWith=ScriptState] Promise<void> enable();
- [CallWith=ScriptState] Promise<void> disable();
- [CallWith=ScriptState] Promise<void> setHeaderValue(ByteString value);
- [CallWith=ScriptState] Promise<NavigationPreloadState> getState();
+ // TODO(mgiuca): Put SecureContext on the interface, not individual methods.
+ // Currently prevented due to clash with OriginTrialEnabled. This can be
+ // resolved either when OriginTrialEnabled is removed, or
+ // https://crbug.com/695123 is fixed.
+ [SecureContext, CallWith=ScriptState] Promise<void> enable();
+ [SecureContext, CallWith=ScriptState] Promise<void> disable();
+ [SecureContext, CallWith=ScriptState] Promise<void> setHeaderValue(ByteString value);
+ [SecureContext, CallWith=ScriptState] Promise<NavigationPreloadState> getState();
};
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_utilities.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698