Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

Issue 2780093003: V8 bindings gen: Error if OriginTrialEnabled and SecureContext together. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
index 28a10f002ee8b361952342a33d6d81576bc7003b..08ce2c350f1d4fe716ce9967041b8154eb0d65a0 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
@@ -65,7 +65,8 @@ void installConditionalFeaturesForModules(
v8::Local<v8::Object>(),
prototypeObject, interfaceObject);
}
- // Mimics the [SecureContext] extended attribute.
+ // Mimics the [SecureContext] extended attribute. Work-around for
+ // https://crbug.com/695123.
if (OriginTrials::webUSBEnabled(executionContext) &&
executionContext->isSecureContext()) {
V8NavigatorPartial::installWebUSB(isolate, world, v8::Local<v8::Object>(),
@@ -81,7 +82,8 @@ void installConditionalFeaturesForModules(
V8WindowPartial::installImageCapture(isolate, world, instanceObject,
prototypeObject, interfaceObject);
}
- // Mimics the [SecureContext] extended attribute.
+ // Mimics the [SecureContext] extended attribute. Work-around for
+ // https://crbug.com/695123.
if (OriginTrials::webUSBEnabled(executionContext) &&
executionContext->isSecureContext()) {
V8WindowPartial::installWebUSB(isolate, world, instanceObject,
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698