runtime/bin/socket_patch.dart - Issue 2780063002: Pulled a significant portion of Socket implementation into BaseSocket in order to prepare for the s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_patch.dart

Issue 2780063002: Pulled a significant portion of Socket implementation into BaseSocket in order to prepare for the s… (Closed)

Patch Set: Changed TARGET_OS_* to HOST_OS_*, removed extra include Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket_patch.dart

diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart

index 5c87fed28f3ea86d216b488f05fe465d272f8278..bbfceb8687e1b481dc7388dfd0dee6ee59bd8540 100644

--- a/runtime/bin/socket_patch.dart

+++ b/runtime/bin/socket_patch.dart

@@ -1064,7 +1064,7 @@ class _NativeSocket extends _NativeSocketNativeWrapper with _ServiceObject {

nativeCreateConnect(List<int> addr, int port) native "Socket_CreateConnect";

nativeCreateBindConnect(List<int> addr, int port, List<int> sourceAddr)

native "Socket_CreateBindConnect";

- bool isBindError(int errorNumber) native "Socket_IsBindError";

+ bool isBindError(int errorNumber) native "SocketBase_IsBindError";

nativeCreateBindListen(List<int> addr, int port, int backlog, bool v6Only,

bool shared) native "ServerSocket_CreateBindListen";

nativeCreateBindDatagram(List<int> addr, int port, bool reuseAddress)