Pulled a significant portion of Socket implementation into BaseSocket in order to prepare for the s…

runtime/bin/socket_base_unsupported.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if defined(DART_IO_DISABLED)
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
 #include "include/dart_api.h"
 
 namespace dart {
 namespace bin {
 
 bool short_socket_read = false;
 
 bool short_socket_write = false;
 
 void FUNCTION_NAME(InternetAddress_Parse)(Dart_NativeArguments args) {
   Dart_ThrowException(
       DartUtils::NewDartArgumentError("Sockets unsupported on this platform"));
 }
 
 
 void FUNCTION_NAME(NetworkInterface_ListSupported)(Dart_NativeArguments args) {
   Dart_ThrowException(
       DartUtils::NewDartArgumentError("Sockets unsupported on this platform"));
 }
 
 
 void FUNCTION_NAME(Socket_CreateConnect)(Dart_NativeArguments args) {

[zra, 2017/04/02 21:39:27]

For consistency, these should also go back to socket_unsupported.cc

[bkonyi, 2017/04/02 22:09:28]

Done.

   Dart_ThrowException(
       DartUtils::NewDartArgumentError("Sockets unsupported on this platform"));
 }
 
 
 void FUNCTION_NAME(Socket_CreateBindConnect)(Dart_NativeArguments args) {
   Dart_ThrowException(
       DartUtils::NewDartArgumentError("Sockets unsupported on this platform"));
 }
 
 
-void FUNCTION_NAME(Socket_IsBindError)(Dart_NativeArguments args) {
+void FUNCTION_NAME(SocketBase_IsBindError)(Dart_NativeArguments args) {
   Dart_ThrowException(
       DartUtils::NewDartArgumentError("Sockets unsupported on this platform"));
 }
 
 
 void FUNCTION_NAME(Socket_CreateBindDatagram)(Dart_NativeArguments args) {
   Dart_ThrowException(
       DartUtils::NewDartArgumentError("Sockets unsupported on this platform"));
 }
 
@@ skipping 102 matching lines @@
 
 void FUNCTION_NAME(Socket_LeaveMulticast)(Dart_NativeArguments args) {
   Dart_ThrowException(
       DartUtils::NewDartArgumentError("Sockets unsupported on this platform"));
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(DART_IO_DISABLED)