Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2780053002: Add app list button long press action (Closed)

Created:
3 years, 8 months ago by xc
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sadrul, Matt Giuca, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), qsr+mojo_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add app list button long press action TEST=locally on device, try long press and see the action handled BUG=b:36522311 Review-Url: https://codereview.chromium.org/2780053002 Cr-Commit-Position: refs/heads/master@{#461285} Committed: https://chromium.googlesource.com/chromium/src/+/dad576a51b2a29433e8c86fd29b092d32559c628

Patch Set 1 #

Patch Set 2 : fix ripple after finger lift #

Total comments: 21

Patch Set 3 : fix comments and add tests #

Total comments: 30

Patch Set 4 : fix comments #

Total comments: 17

Patch Set 5 : fix comments #

Total comments: 8

Patch Set 6 : fix comments #

Patch Set 7 : missed updating ExampleAppListPresenter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -25 lines) Patch
M ash/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/shelf/app_list_button.h View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M ash/common/shelf/app_list_button.cc View 1 2 3 4 5 chunks +56 lines, -22 lines 0 comments Download
A ash/common/shelf/app_list_button_unittest.cc View 1 2 3 4 5 1 chunk +76 lines, -0 lines 0 comments Download
M ash/shell/example_app_list_presenter.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell/example_app_list_presenter.cc View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_presenter_service.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_presenter_service.cc View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M ui/app_list/presenter/app_list.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/presenter/app_list.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter.mojom View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/presenter/test/test_app_list_presenter.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/presenter/test/test_app_list_presenter.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 46 (22 generated)
xc
Please take a first look at if this is the approach we agreed on. If ...
3 years, 8 months ago (2017-03-28 23:05:41 UTC) #3
msw
The approach seems fine, my comments are mostly about naming. https://codereview.chromium.org/2780053002/diff/20001/ash/common/shelf/app_list_button.cc File ash/common/shelf/app_list_button.cc (right): https://codereview.chromium.org/2780053002/diff/20001/ash/common/shelf/app_list_button.cc#newcode107 ...
3 years, 8 months ago (2017-03-29 00:24:53 UTC) #4
xc
PTAL https://codereview.chromium.org/2780053002/diff/20001/ash/common/shelf/app_list_button.cc File ash/common/shelf/app_list_button.cc (right): https://codereview.chromium.org/2780053002/diff/20001/ash/common/shelf/app_list_button.cc#newcode107 ash/common/shelf/app_list_button.cc:107: LOG(ERROR) << "XXC: event type " << event->type(); ...
3 years, 8 months ago (2017-03-29 21:34:49 UTC) #5
msw
Nice, I have lots of nits, but that's just how I review :) https://codereview.chromium.org/2780053002/diff/20001/ui/app_list/presenter/app_list.h File ...
3 years, 8 months ago (2017-03-29 22:17:42 UTC) #6
xc
PTAL https://codereview.chromium.org/2780053002/diff/40001/ash/common/shelf/app_list_button.cc File ash/common/shelf/app_list_button.cc (right): https://codereview.chromium.org/2780053002/diff/40001/ash/common/shelf/app_list_button.cc#newcode137 ash/common/shelf/app_list_button.cc:137: if (IsVoiceInteractionEnabled()) { On 2017/03/29 22:17:41, msw wrote: ...
3 years, 8 months ago (2017-03-30 00:36:00 UTC) #7
msw
I suggest you take the easy road via "// views::ImageButton overrides:" https://codereview.chromium.org/2780053002/diff/60001/ash/common/shelf/app_list_button.cc File ash/common/shelf/app_list_button.cc (right): ...
3 years, 8 months ago (2017-03-30 01:07:09 UTC) #8
xc
https://codereview.chromium.org/2780053002/diff/60001/ash/common/shelf/app_list_button.cc File ash/common/shelf/app_list_button.cc (right): https://codereview.chromium.org/2780053002/diff/60001/ash/common/shelf/app_list_button.cc#newcode145 ash/common/shelf/app_list_button.cc:145: } On 2017/03/30 01:07:05, msw wrote: > oops; this ...
3 years, 8 months ago (2017-03-30 17:19:36 UTC) #9
msw
lgtm, thanks for putting up with my comments!
3 years, 8 months ago (2017-03-30 18:03:36 UTC) #10
xc
Thank you for the quick and detailed reviews.
3 years, 8 months ago (2017-03-30 18:07:14 UTC) #11
xiyuan
lgtm with nits tsepez@, could you review the mojom changes? https://codereview.chromium.org/2780053002/diff/80001/ash/common/shelf/app_list_button_unittest.cc File ash/common/shelf/app_list_button_unittest.cc (right): https://codereview.chromium.org/2780053002/diff/80001/ash/common/shelf/app_list_button_unittest.cc#newcode35 ...
3 years, 8 months ago (2017-03-30 18:14:24 UTC) #15
Tom Sepez
what's a voice interaction session? Can an untrusted client start one without making the end ...
3 years, 8 months ago (2017-03-30 18:17:27 UTC) #16
xc
https://codereview.chromium.org/2780053002/diff/80001/ash/common/shelf/app_list_button_unittest.cc File ash/common/shelf/app_list_button_unittest.cc (right): https://codereview.chromium.org/2780053002/diff/80001/ash/common/shelf/app_list_button_unittest.cc#newcode35 ash/common/shelf/app_list_button_unittest.cc:35: void OnGestureEvent(ui::GestureEvent* event) { On 2017/03/30 18:14:24, xiyuan wrote: ...
3 years, 8 months ago (2017-03-30 18:34:55 UTC) #17
Tom Sepez
LGTM per offline discussion.
3 years, 8 months ago (2017-03-30 18:36:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780053002/100001
3 years, 8 months ago (2017-03-31 03:40:30 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/395498)
3 years, 8 months ago (2017-03-31 04:15:28 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780053002/120001
3 years, 8 months ago (2017-03-31 16:51:49 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/43930)
3 years, 8 months ago (2017-03-31 17:05:55 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780053002/120001
3 years, 8 months ago (2017-03-31 17:47:07 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/395860)
3 years, 8 months ago (2017-03-31 17:56:16 UTC) #36
xc
Add oshima@ for owners review on ash/shell/example_app_list_presenter.*
3 years, 8 months ago (2017-03-31 18:28:56 UTC) #38
xc
Saw oshima@ OOO this pm, also adding derat@ for owners review on ash/shell/example_app_list_presenter.*
3 years, 8 months ago (2017-03-31 20:24:34 UTC) #40
Daniel Erat
lgtm for //ash/shell
3 years, 8 months ago (2017-03-31 20:47:35 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780053002/120001
3 years, 8 months ago (2017-03-31 21:29:57 UTC) #43
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 00:24:05 UTC) #46
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/dad576a51b2a29433e8c86fd29b0...

Powered by Google App Engine
This is Rietveld 408576698