Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3190)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)
Patch Set: Fix browser tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index 84501e03c35c3b57257d02b5686af17248634277..0f17c26d17700fca12dca61748ba42e033488387 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -410,15 +410,17 @@ TEST_F(CorePageLoadMetricsObserverTest, Reload) {
NavigateWithPageTransitionAndCommit(url, ui::PAGE_TRANSITION_RELOAD);
SimulateTimingUpdate(timing);
- page_load_metrics::ExtraRequestInfo resources[] = {
+ page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
false /* data_reduction_proxy_used*/,
- 0 /* original_network_content_length */},
+ 0 /* original_network_content_length */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
false /* data_reduction_proxy_used*/,
- 1024 * 40 /* original_network_content_length */},
+ 1024 * 40 /* original_network_content_length */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
};
int64_t network_bytes = 0;
@@ -495,15 +497,17 @@ TEST_F(CorePageLoadMetricsObserverTest, ForwardBack) {
ui::PAGE_TRANSITION_FORWARD_BACK));
SimulateTimingUpdate(timing);
- page_load_metrics::ExtraRequestInfo resources[] = {
+ page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
false /* data_reduction_proxy_used*/,
- 0 /* original_network_content_length */},
+ 0 /* original_network_content_length */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
false /* data_reduction_proxy_used*/,
- 1024 * 40 /* original_network_content_length */},
+ 1024 * 40 /* original_network_content_length */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
};
int64_t network_bytes = 0;
@@ -574,15 +578,17 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
NavigateWithPageTransitionAndCommit(url, ui::PAGE_TRANSITION_LINK);
SimulateTimingUpdate(timing);
- page_load_metrics::ExtraRequestInfo resources[] = {
+ page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
false /* data_reduction_proxy_used*/,
- 0 /* original_network_content_length */},
+ 0 /* original_network_content_length */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
false /* data_reduction_proxy_used*/,
- 1024 * 40 /* original_network_content_length */},
+ 1024 * 40 /* original_network_content_length */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
};
int64_t network_bytes = 0;

Powered by Google App Engine
This is Rietveld 408576698