Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4914)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)
Patch Set: FREEZE.unindexed - took merge and fixed it up Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index db9a01caa0f514dc732175b0aacdafec18503b12..7fac352d2a52a9230489be2b79d120971ba9559c 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -415,15 +415,17 @@ TEST_F(CorePageLoadMetricsObserverTest, Reload) {
NavigateWithPageTransitionAndCommit(url, ui::PAGE_TRANSITION_RELOAD);
SimulateTimingUpdate(timing);
- page_load_metrics::ExtraRequestInfo resources[] = {
+ page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
0 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */},
+ nullptr /* data_reduction_proxy_data */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */},
+ nullptr /* data_reduction_proxy_data */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
};
int64_t network_bytes = 0;
@@ -501,15 +503,17 @@ TEST_F(CorePageLoadMetricsObserverTest, ForwardBack) {
ui::PAGE_TRANSITION_FORWARD_BACK));
SimulateTimingUpdate(timing);
- page_load_metrics::ExtraRequestInfo resources[] = {
+ page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
0 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */},
+ nullptr /* data_reduction_proxy_data */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */},
+ nullptr /* data_reduction_proxy_data */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
};
int64_t network_bytes = 0;
@@ -581,15 +585,17 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
NavigateWithPageTransitionAndCommit(url, ui::PAGE_TRANSITION_LINK);
SimulateTimingUpdate(timing);
- page_load_metrics::ExtraRequestInfo resources[] = {
+ page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
0 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */},
+ nullptr /* data_reduction_proxy_data */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */},
+ nullptr /* data_reduction_proxy_data */,
+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
};
int64_t network_bytes = 0;

Powered by Google App Engine
This is Rietveld 408576698