chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc - Issue 2780003003: Send an event to the page load metrics to track resource starting.

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)

Patch Set: Second round of RyanSturm feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer_unittest.cc ('K') | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h » ('j') | chrome/browser/page_load_metrics/page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

index 7e2822338f2249f28161de7ea7e196a842ccc9a7..eaa40afb5ed3f8cc62d6ba749ed1d8b482606a3d 100644

--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

@@ -156,7 +156,8 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {

SimulateLoadedResource({false /* was_cached */,

1024 * 40 /* raw_body_bytes */,

false /* data_reduction_proxy_used */,

- 0 /* original_network_content_length */});

+ 0 /* original_network_content_length */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

@@ -168,11 +169,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {

SimulateLoadedResource({false /* was_cached */,

1024 * 20 /* raw_body_bytes */,

false /* data_reduction_proxy_used */,

- 0 /* original_network_content_length */});

+ 0 /* original_network_content_length */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,

false /* data_reduction_proxy_used */,

- 0 /* original_network_content_length */});

+ 0 /* original_network_content_length */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

histogram_tester().ExpectTotalCount(

internal::kHistogramSubresourceFilterCount, 1);

@@ -251,7 +254,8 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {

SimulateLoadedResource({false /* was_cached */,

1024 * 40 /* raw_body_bytes */,

false /* data_reduction_proxy_used */,

- 0 /* original_network_content_length */});

+ 0 /* original_network_content_length */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

@@ -263,11 +267,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {

SimulateLoadedResource({false /* was_cached */,

1024 * 20 /* raw_body_bytes */,

false /* data_reduction_proxy_used */,

- 0 /* original_network_content_length */});

+ 0 /* original_network_content_length */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,

false /* data_reduction_proxy_used */,

- 0 /* original_network_content_length */});

+ 0 /* original_network_content_length */,

+ content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});

histogram_tester().ExpectTotalCount(

internal::kHistogramSubresourceFilterCount, 1);