chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc - Issue 2780003003: Send an event to the page load metrics to track resource starting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)

Patch Set: Second round of RyanSturm feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc ('K') | « chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc » ('j') | chrome/browser/page_load_metrics/observers/resource_tracking_page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc

index 6e73c491b3d181920b2c7f401bf84d09a21a68ad..57a131c0b22a04113f03c88cf21263a602450b75 100644

--- a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc

@@ -24,11 +24,12 @@ MediaPageLoadMetricsObserver::MediaPageLoadMetricsObserver()

MediaPageLoadMetricsObserver::~MediaPageLoadMetricsObserver() = default;

void MediaPageLoadMetricsObserver::OnLoadedResource(

- const page_load_metrics::ExtraRequestInfo& extra_request_info) {

- if (extra_request_info.was_cached) {

- cache_bytes_ += extra_request_info.raw_body_bytes;

+ const page_load_metrics::ExtraRequestCompleteInfo&

+ extra_request_complete_info) {

+ if (extra_request_complete_info.was_cached) {

+ cache_bytes_ += extra_request_complete_info.raw_body_bytes;

} else {

- network_bytes_ += extra_request_info.raw_body_bytes;

+ network_bytes_ += extra_request_complete_info.raw_body_bytes;

}