Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)
Patch Set: Fix browser tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h" 5 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_ observer.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h" 8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h"
9 9
10 namespace { 10 namespace {
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 histogram_tester().ExpectTotalCount( 138 histogram_tester().ExpectTotalCount(
139 internal::kHistogramSubresourceFilterForegroundDuration, 1); 139 internal::kHistogramSubresourceFilterForegroundDuration, 1);
140 } 140 }
141 141
142 TEST_F(SubresourceFilterMetricsObserverTest, Subresources) { 142 TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
143 NavigateAndCommit(GURL(kDefaultTestUrl)); 143 NavigateAndCommit(GURL(kDefaultTestUrl));
144 144
145 SimulateLoadedResource({false /* was_cached */, 145 SimulateLoadedResource({false /* was_cached */,
146 1024 * 40 /* raw_body_bytes */, 146 1024 * 40 /* raw_body_bytes */,
147 false /* data_reduction_proxy_used */, 147 false /* data_reduction_proxy_used */,
148 0 /* original_network_content_length */}); 148 0 /* original_network_content_length */,
149 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
149 150
150 page_load_metrics::PageLoadTiming timing; 151 page_load_metrics::PageLoadTiming timing;
151 timing.navigation_start = base::Time::FromDoubleT(1); 152 timing.navigation_start = base::Time::FromDoubleT(1);
152 page_load_metrics::PageLoadMetadata metadata; 153 page_load_metrics::PageLoadMetadata metadata;
153 metadata.behavior_flags |= 154 metadata.behavior_flags |=
154 blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch; 155 blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
155 SimulateTimingAndMetadataUpdate(timing, metadata); 156 SimulateTimingAndMetadataUpdate(timing, metadata);
156 157
157 SimulateLoadedResource({false /* was_cached */, 158 SimulateLoadedResource({false /* was_cached */,
158 1024 * 20 /* raw_body_bytes */, 159 1024 * 20 /* raw_body_bytes */,
159 false /* data_reduction_proxy_used */, 160 false /* data_reduction_proxy_used */,
160 0 /* original_network_content_length */}); 161 0 /* original_network_content_length */,
162 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
161 163
162 SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */, 164 SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
163 false /* data_reduction_proxy_used */, 165 false /* data_reduction_proxy_used */,
164 0 /* original_network_content_length */}); 166 0 /* original_network_content_length */,
167 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
165 168
166 histogram_tester().ExpectTotalCount( 169 histogram_tester().ExpectTotalCount(
167 internal::kHistogramSubresourceFilterCount, 1); 170 internal::kHistogramSubresourceFilterCount, 1);
168 171
169 // Navigate away from the current page to force logging of request and byte 172 // Navigate away from the current page to force logging of request and byte
170 // metrics. 173 // metrics.
171 NavigateToUntrackedUrl(); 174 NavigateToUntrackedUrl();
172 175
173 histogram_tester().ExpectTotalCount( 176 histogram_tester().ExpectTotalCount(
174 internal::kHistogramSubresourceFilterTotalResources, 1); 177 internal::kHistogramSubresourceFilterTotalResources, 1);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 } 236 }
234 237
235 TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) { 238 TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
236 NavigateAndCommit(GURL(kDefaultTestUrl)); 239 NavigateAndCommit(GURL(kDefaultTestUrl));
237 240
238 SimulateMediaPlayed(); 241 SimulateMediaPlayed();
239 242
240 SimulateLoadedResource({false /* was_cached */, 243 SimulateLoadedResource({false /* was_cached */,
241 1024 * 40 /* raw_body_bytes */, 244 1024 * 40 /* raw_body_bytes */,
242 false /* data_reduction_proxy_used */, 245 false /* data_reduction_proxy_used */,
243 0 /* original_network_content_length */}); 246 0 /* original_network_content_length */,
247 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
244 248
245 page_load_metrics::PageLoadTiming timing; 249 page_load_metrics::PageLoadTiming timing;
246 timing.navigation_start = base::Time::FromDoubleT(1); 250 timing.navigation_start = base::Time::FromDoubleT(1);
247 page_load_metrics::PageLoadMetadata metadata; 251 page_load_metrics::PageLoadMetadata metadata;
248 metadata.behavior_flags |= 252 metadata.behavior_flags |=
249 blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch; 253 blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
250 SimulateTimingAndMetadataUpdate(timing, metadata); 254 SimulateTimingAndMetadataUpdate(timing, metadata);
251 255
252 SimulateLoadedResource({false /* was_cached */, 256 SimulateLoadedResource({false /* was_cached */,
253 1024 * 20 /* raw_body_bytes */, 257 1024 * 20 /* raw_body_bytes */,
254 false /* data_reduction_proxy_used */, 258 false /* data_reduction_proxy_used */,
255 0 /* original_network_content_length */}); 259 0 /* original_network_content_length */,
260 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
256 261
257 SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */, 262 SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
258 false /* data_reduction_proxy_used */, 263 false /* data_reduction_proxy_used */,
259 0 /* original_network_content_length */}); 264 0 /* original_network_content_length */,
265 content::ResourceType::RESOURCE_TYPE_MAIN_FRAME});
260 266
261 histogram_tester().ExpectTotalCount( 267 histogram_tester().ExpectTotalCount(
262 internal::kHistogramSubresourceFilterCount, 1); 268 internal::kHistogramSubresourceFilterCount, 1);
263 269
264 // Navigate away from the current page to force logging of request and byte 270 // Navigate away from the current page to force logging of request and byte
265 // metrics. 271 // metrics.
266 NavigateToUntrackedUrl(); 272 NavigateToUntrackedUrl();
267 273
268 histogram_tester().ExpectTotalCount( 274 histogram_tester().ExpectTotalCount(
269 internal::kHistogramSubresourceFilterTotalResources, 1); 275 internal::kHistogramSubresourceFilterTotalResources, 1);
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 histogram_tester().ExpectTotalCount( 325 histogram_tester().ExpectTotalCount(
320 internal::kHistogramSubresourceFilterMediaNetworkBytes, 1); 326 internal::kHistogramSubresourceFilterMediaNetworkBytes, 1);
321 histogram_tester().ExpectBucketCount( 327 histogram_tester().ExpectBucketCount(
322 internal::kHistogramSubresourceFilterMediaNetworkBytes, 60, 1); 328 internal::kHistogramSubresourceFilterMediaNetworkBytes, 60, 1);
323 329
324 histogram_tester().ExpectTotalCount( 330 histogram_tester().ExpectTotalCount(
325 internal::kHistogramSubresourceFilterMediaCacheBytes, 1); 331 internal::kHistogramSubresourceFilterMediaCacheBytes, 1);
326 histogram_tester().ExpectBucketCount( 332 histogram_tester().ExpectBucketCount(
327 internal::kHistogramSubresourceFilterMediaCacheBytes, 10, 1); 333 internal::kHistogramSubresourceFilterMediaCacheBytes, 10, 1);
328 } 334 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698