Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2780003003: Send an event to the page load metrics to track resource starting. (Closed)
Patch Set: Fix browser tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_
7 7
8 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" 8 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
9 9
10 namespace internal { 10 namespace internal {
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 124 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
125 void OnComplete(const page_load_metrics::PageLoadTiming& timing, 125 void OnComplete(const page_load_metrics::PageLoadTiming& timing,
126 const page_load_metrics::PageLoadExtraInfo& info) override; 126 const page_load_metrics::PageLoadExtraInfo& info) override;
127 void OnFailedProvisionalLoad( 127 void OnFailedProvisionalLoad(
128 const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info, 128 const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
129 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 129 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
130 ObservePolicy FlushMetricsOnAppEnterBackground( 130 ObservePolicy FlushMetricsOnAppEnterBackground(
131 const page_load_metrics::PageLoadTiming& timing, 131 const page_load_metrics::PageLoadTiming& timing,
132 const page_load_metrics::PageLoadExtraInfo& info) override; 132 const page_load_metrics::PageLoadExtraInfo& info) override;
133 void OnUserInput(const blink::WebInputEvent& event) override; 133 void OnUserInput(const blink::WebInputEvent& event) override;
134 void OnLoadedResource( 134 void OnLoadedResource(const page_load_metrics::ExtraRequestCompleteInfo&
135 const page_load_metrics::ExtraRequestInfo& extra_request_info) override; 135 extra_request_info) override;
RyanSturm 2017/04/14 20:08:43 nit: s/extra_request_info/extra_request_complete_i
Pete Williamson 2017/04/17 18:53:11 Done everywhere.
136 136
137 private: 137 private:
138 void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing, 138 void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing,
139 const page_load_metrics::PageLoadExtraInfo& info); 139 const page_load_metrics::PageLoadExtraInfo& info);
140 void RecordByteAndResourceHistograms( 140 void RecordByteAndResourceHistograms(
141 const page_load_metrics::PageLoadTiming& timing, 141 const page_load_metrics::PageLoadTiming& timing,
142 const page_load_metrics::PageLoadExtraInfo& info); 142 const page_load_metrics::PageLoadExtraInfo& info);
143 void RecordRappor(const page_load_metrics::PageLoadTiming& timing, 143 void RecordRappor(const page_load_metrics::PageLoadTiming& timing,
144 const page_load_metrics::PageLoadExtraInfo& info); 144 const page_load_metrics::PageLoadExtraInfo& info);
145 void RecordForegroundDurationHistograms( 145 void RecordForegroundDurationHistograms(
(...skipping 22 matching lines...) Expand all
168 // True if we've received a scroll input after first paint has happened. 168 // True if we've received a scroll input after first paint has happened.
169 bool received_scroll_input_after_first_paint_ = false; 169 bool received_scroll_input_after_first_paint_ = false;
170 170
171 base::TimeTicks first_user_interaction_after_first_paint_; 171 base::TimeTicks first_user_interaction_after_first_paint_;
172 base::TimeTicks first_paint_; 172 base::TimeTicks first_paint_;
173 173
174 DISALLOW_COPY_AND_ASSIGN(CorePageLoadMetricsObserver); 174 DISALLOW_COPY_AND_ASSIGN(CorePageLoadMetricsObserver);
175 }; 175 };
176 176
177 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBS ERVER_H_ 177 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBS ERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698