Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: components/user_manager/user_manager_base.h

Issue 2779973007: cros: Fix flaky owner detection (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_manager/user_manager_base.h
diff --git a/components/user_manager/user_manager_base.h b/components/user_manager/user_manager_base.h
index dbf8ebe8a75487dedc94a586df7fdeaa76297562..70776a72077441725ab4f296962a28b52f8453fa 100644
--- a/components/user_manager/user_manager_base.h
+++ b/components/user_manager/user_manager_base.h
@@ -251,8 +251,6 @@ class USER_MANAGER_EXPORT UserManagerBase : public UserManager {
// Getters/setters for private members.
- virtual void SetCurrentUserIsOwner(bool is_current_user_owner);
-
virtual bool GetEphemeralUsersEnabled() const;
virtual void SetEphemeralUsersEnabled(bool enabled);
@@ -345,11 +343,6 @@ class USER_MANAGER_EXPORT UserManagerBase : public UserManager {
// Indicates stage of loading user from prefs.
UserLoadStage user_loading_stage_ = STAGE_NOT_LOADED;
- // Cached flag of whether currently logged-in user is owner or not.
- // May be accessed on different threads, requires locking.
- bool is_current_user_owner_ = false;
- mutable base::Lock is_current_user_owner_lock_;
xiyuan 2017/04/03 19:02:56 The comment and the lock is obsolete. Both IsCurr
-
// Cached flag of whether the currently logged-in user existed before this
// login.
bool is_current_user_new_ = false;

Powered by Google App Engine
This is Rietveld 408576698