cros: Fix flaky owner detection

chrome/browser/chromeos/settings/device_settings_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 440 matching lines @@
 
   EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
   EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
   device_settings_service_.PropertyChangeComplete(true);
   FlushDeviceSettings();
   Mock::VerifyAndClearExpectations(&observer_);
 
   device_settings_service_.RemoveObserver(&observer_);
 }
 
+TEST_F(DeviceSettingsServiceTest, LoadDeferredDuringOwnershipEastablishment) {

[achuithb, 2017/04/04 19:38:34]

Please add a comment explaining what this test is testing.

Also Eastablishmet->Establishment

[xiyuan, 2017/04/04 20:17:50]

Done and done.

+  owner_key_util_->Clear();
+
+  EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
+  EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
+  EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
+            device_settings_service_.GetOwnershipStatus());
+
+  // Mark ownership establishment is running.
+  device_settings_service_.MarkWillEstablishConsumerOwnership();
+
+  const std::string& user_id = device_policy_.policy_data().username();
+  owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
+  InitOwner(AccountId::FromUserEmail(user_id), false);
+  OwnerSettingsServiceChromeOS* service =
+      OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get());
+  ASSERT_TRUE(service);
+  service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner,
+                                   base::Unretained(this)));
+  ReloadDeviceSettings();
+
+  // No load operation should happen until OwnerSettingsService loads the
+  // private key.
+  EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
+  ASSERT_FALSE(device_settings_service_.GetPublicKey().get());
+  EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
+            device_settings_service_.GetOwnershipStatus());
+  EXPECT_FALSE(is_owner_set_);
+
+  // Load the private key and trigger a reload. Load operations should finish.
+  owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());
+  service->OnTPMTokenReady(true /* is ready */);
+  FlushDeviceSettings();
+
+  // Verify owner key is loaded and ownership status is updated.
+  EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());
+  ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
+  ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
+  EXPECT_EQ(device_policy_.GetPublicSigningKeyAsString(),
+            device_settings_service_.GetPublicKey()->as_string());
+  EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
+            device_settings_service_.GetOwnershipStatus());
+  EXPECT_TRUE(is_owner_set_);
+  EXPECT_TRUE(is_owner_);
+}
+
 }  // namespace chromeos