views: fold layout_utils::CreatePanelLayout into GridLayout::CreatePanel

ui/views/layout/grid_layout.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/layout/grid_layout.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/view.h"
+#include "ui/views/views_delegate.h"
 #include "ui/views/window/dialog_delegate.h"
 
 namespace views {
 
 // LayoutElement ------------------------------------------------------
 
 // A LayoutElement has a size and location along one axis. It contains
 // methods that are used along both axis.
 class LayoutElement {
  public:
@@ skipping 620 matching lines @@
       adding_view_(false) {
   DCHECK(host);
 }
 
 GridLayout::~GridLayout() {
 }
 
 // static
 GridLayout* GridLayout::CreatePanel(View* host) {
   GridLayout* layout = new GridLayout(host);
-  layout->SetInsets(kPanelVertMargin, kButtonHEdgeMarginNew,
-                    kPanelVertMargin, kButtonHEdgeMarginNew);
+  layout->SetInsets(ViewsDelegate::GetInstance()->GetInsetsMetric(
+      InsetsMetric::BUBBLE_DIALOG));

[Peter Kasting, 2017/03/29 03:39:11]

Did you choose to use BUBBLE_DIALOG because it was close to the desired
behavior, and the previous behavior is hard to duplicate with existing metrics?

I'm worried about the visible effects of this behavior change.  Can you take a
sample screenshot of a place this would affect?

Unless this is a concrete visual improvement, I'm inclined to suggest we add the
necessary plumbing to ViewsDelegate (e.g. another inset enum value) to duplicate
the old behavior.

+  host->SetLayoutManager(layout);

[Peter Kasting, 2017/03/29 03:39:11]

Can you also audit the existing CreatePanel() calls and remove all the
SetLayoutManager() calls that existed because this wasn't here?

(Were any places NOT doing SetLayoutManager()?)

   return layout;
 }
 
 void GridLayout::SetInsets(int top, int left, int bottom, int right) {
   insets_.Set(top, left, bottom, right);
 }
 
 void GridLayout::SetInsets(const gfx::Insets& insets) {
   insets_ = insets;
 }
@@ skipping 360 matching lines @@
 
 ColumnSet* GridLayout::GetLastValidColumnSet() {
   for (int i = current_row_ - 1; i >= 0; --i) {
     if (rows_[i]->column_set())
       return rows_[i]->column_set();
   }
   return nullptr;
 }
 
 }  // namespace views