Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 277993002: Add target_build_type flag to bisect-perf-regression tool to enable bisecting of a Debug build with… (Closed)

Created:
6 years, 7 months ago by rmcilroy
Modified:
6 years, 7 months ago
Reviewers:
qyearsley
CC:
chromium-reviews
Visibility:
Public.

Description

Add target_build_type flag to bisect-perf-regression tool to enable bisecting of a Debug build with run-bisect-manual-test.py tool. The run-bisect-manual-test.py uses bisect-perf-regression.py under the hood, and currently it is not possible to bisect a Debug build this way. This CL addresses this. Also fixes browser.Start() / browser.Close() in manual-test.py. BUG=370373 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M tools/bisect-manual-test.py View 2 chunks +0 lines, -5 lines 0 comments Download
M tools/bisect-perf-regression.py View 10 chunks +22 lines, -15 lines 0 comments Download
M tools/run-bisect-manual-test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rmcilroy
PTAL Quinten, thanks!
6 years, 7 months ago (2014-05-09 15:22:02 UTC) #1
qyearsley
On 2014/05/09 15:22:02, rmcilroy wrote: > PTAL Quinten, thanks! I don't see any problems WRT ...
6 years, 7 months ago (2014-05-09 23:27:48 UTC) #2
rmcilroy
On 2014/05/09 23:27:48, qyearsley wrote: > On 2014/05/09 15:22:02, rmcilroy wrote: > > PTAL Quinten, ...
6 years, 7 months ago (2014-05-12 09:51:03 UTC) #3
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 7 months ago (2014-05-12 09:51:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/277993002/1
6 years, 7 months ago (2014-05-12 09:51:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 14:53:08 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 17:34:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/14929)
6 years, 7 months ago (2014-05-12 17:34:19 UTC) #8
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 7 months ago (2014-05-12 17:49:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/277993002/1
6 years, 7 months ago (2014-05-12 17:50:10 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 18:10:30 UTC) #11
Message was sent while issue was closed.
Change committed as 269815

Powered by Google App Engine
This is Rietveld 408576698