ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h - Issue 2779843006: Add favicon view to ContentSuggestionsArticle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h

Issue 2779843006: Add favicon view to ContentSuggestionsArticle (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn ('k') | ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h

diff --git a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h

index 994c7e6b66b8147d23a4e92fa5f0e713247092ac..3335a7a5e616ca531c95c975fb0f135033607165 100644

--- a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h

+++ b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h

@@ -14,6 +14,8 @@ class Time;

}

@class ContentSuggestionsArticleItem;

+@class FaviconAttributes;

+@class FaviconViewNew;

class GURL;

// Delegate for a ContentSuggestionsArticleItem.

@@ -44,6 +46,8 @@ class GURL;

@property(nonatomic, copy) NSString* publisher;

@property(nonatomic, assign) base::Time publishDate;

@property(nonatomic, weak) id<ContentSuggestionsArticleItemDelegate> delegate;

+// Attributes for favicon.

+@property(nonatomic, strong) FaviconAttributes* attributes;

@end

@@ -52,6 +56,8 @@ class GURL;

@property(nonatomic, readonly, strong) UILabel* titleLabel;

@property(nonatomic, readonly, strong) UILabel* subtitleLabel;

+// View for displaying the favicon.

+@property(nonatomic, readonly, strong) FaviconViewNew* faviconView;

// Sets an |image| to illustrate the article, replacing the "no image" icon.

- (void)setContentImage:(UIImage*)image;