Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2779843004: Fix top-level inference errors for most of the newly failing tests. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix top-level inference errors for most of the newly failing tests. Update analyzer status files and DDC expections. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cf25e7f5cbee4042c56773094e2f33b978c983c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -71 lines) Patch
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 12 chunks +0 lines, -23 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib_strong/set_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/bailout4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/closure_in_field_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/deferred_not_loaded_check_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/deferred_static_seperate_lib1.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language_strong/first_class_types_constants_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language_strong/generic_field_mixin4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/generic_field_mixin5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/inferrer_closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/language_strong.status View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/language_strong/lazy_static2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/lazy_static3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/lazy_static5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/lazy_static6_src.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/lazy_static7_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/super_operator_index2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/super_operator_index3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/super_operator_index4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/convert/streamed_conversion_json_utf8_decode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/convert/streamed_conversion_json_utf8_encode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/lib_strong.status View 2 chunks +0 lines, -7 lines 0 comments Download
M tests/lib_strong/mirrors/invocation_fuzz_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-03-28 19:05:55 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-03-28 19:15:10 UTC) #2
scheglov
3 years, 8 months ago (2017-03-28 19:16:19 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cf25e7f5cbee4042c56773094e2f33b978c983c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698