third_party/WebKit/Source/core/editing/EditingUtilities.h - Issue 2779813002: [InputEvent] Don't modify selection when transpose was canceled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2779813002: [InputEvent] Don't modify selection when transpose was canceled (Closed)

Patch Set: yosin's review: Use const& Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingUtilities.h

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.h b/third_party/WebKit/Source/core/editing/EditingUtilities.h

index 1e3c6bc7733eadd0229d009007735825791547e8..28fc78a9f5f0f2ba3cfc2d53b102a883ad36de7b 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilities.h

+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.h

@@ -438,7 +438,8 @@ const StaticRangeVector* targetRangesForInputEvent(const Node&);

DispatchEventResult dispatchBeforeInputInsertText(

Node*,

const String& data,

- InputEvent::InputType = InputEvent::InputType::InsertText);

+ InputEvent::InputType = InputEvent::InputType::InsertText,

+ const StaticRangeVector* = nullptr);

DispatchEventResult dispatchBeforeInputEditorCommand(Node*,

InputEvent::InputType,

const StaticRangeVector*);