[InputEvent] Don't modify selection when transpose was canceled

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 127 matching lines @@
 
 bool isInPasswordFieldWithUnrevealedPassword(const Position& position) {
   TextControlElement* textControl = enclosingTextControl(position);
   if (!isHTMLInputElement(textControl))
     return false;
   HTMLInputElement* input = toHTMLInputElement(textControl);
   return (input->type() == InputTypeNames::password) &&
          !input->shouldRevealPassword();
 }
 
+EphemeralRange getTransposeRange(LocalFrame& frame) {

[yosin_UTC9, 2017/04/06 04:32:23]

s/getTransposeRange/computeRangeForTranspose/.
Let's avoid using |get| for less confusion of getter of Editor class.

[chongz, 2017/04/07 02:29:22]

Done.

+  VisibleSelection selection =

[yosin_UTC9, 2017/04/06 04:32:23]

nit: s/VisibleSeleciton/const VisibleSelection&/

[chongz, 2017/04/07 02:29:22]

Done.

+      frame.selection().computeVisibleSelectionInDOMTree();
+  if (!selection.isCaret())
+    return EphemeralRange();
+
+  // Make a selection that goes back one character and forward two characters.
+  VisiblePosition caret = selection.visibleStart();

[yosin_UTC9, 2017/04/06 04:32:23]

nit: s/VisiblePosition/const VisiblePositon&/

[chongz, 2017/04/07 02:29:22]

Done.

+  VisiblePosition next =

[yosin_UTC9, 2017/04/06 04:32:23]

nit: s/VisiblePosition/const VisiblePositon&/

[chongz, 2017/04/07 02:29:22]

Done.

+      isEndOfParagraph(caret) ? caret : nextPositionOf(caret);
+  VisiblePosition previous = previousPositionOf(next);

[yosin_UTC9, 2017/04/06 04:32:23]

nit: s/VisiblePosition/const VisiblePositon&/

[chongz, 2017/04/07 02:29:22]

Done.

+  if (next.deepEquivalent() == previous.deepEquivalent())
+    return EphemeralRange();
+  previous = previousPositionOf(previous);

[yosin_UTC9, 2017/04/06 04:32:23]

Could you introduce new variable rather than re-using |previous|?

[chongz, 2017/04/07 02:29:22]

Done.

+  if (!inSameParagraph(next, previous))
+    return EphemeralRange();
+  return makeRange(previous, next);
+}
+
 }  // anonymous namespace
 
 Editor::RevealSelectionScope::RevealSelectionScope(Editor* editor)
     : m_editor(editor) {
   ++m_editor->m_preventRevealSelection;
 }
 
 Editor::RevealSelectionScope::~RevealSelectionScope() {
   DCHECK(m_editor->m_preventRevealSelection);
   --m_editor->m_preventRevealSelection;
@@ skipping 1215 matching lines @@
     return;
   if (!frame().selection().isAvailable())
     return;
   frame().selection().revealSelection(alignment, revealExtentOption);
 }
 
 void Editor::transpose() {
   if (!canEdit())
     return;
 
-  VisibleSelection selection =
-      frame().selection().computeVisibleSelectionInDOMTreeDeprecated();
-  if (!selection.isCaret())
-    return;
+  // TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited. see http://crbug.com/590369 for more details.
+  frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
-  // Make a selection that goes back one character and forward two characters.
-  VisiblePosition caret = selection.visibleStart();
-  VisiblePosition next =
-      isEndOfParagraph(caret) ? caret : nextPositionOf(caret);
-  VisiblePosition previous = previousPositionOf(next);
-  if (next.deepEquivalent() == previous.deepEquivalent())
-    return;
-  previous = previousPositionOf(previous);
-  if (!inSameParagraph(next, previous))
-    return;
-  const EphemeralRange range = makeRange(previous, next);
+  EphemeralRange range = getTransposeRange(frame());

[yosin_UTC9, 2017/04/06 04:32:24]

nit: s/EphemeralRange/const EphemeralRange&/

[chongz, 2017/04/07 02:29:22]

Done.

   if (range.isNull())
     return;
-  const SelectionInDOMTree newSelection =
-      SelectionInDOMTree::Builder().setBaseAndExtent(range).build();
 
   // Transpose the two characters.
   String text = plainText(range);
   if (text.length() != 2)
     return;
   String transposed = text.right(1) + text.left(1);
 
-  // Select the two characters.
-  if (createVisibleSelection(newSelection) !=
-      frame().selection().computeVisibleSelectionInDOMTreeDeprecated())
-    frame().selection().setSelection(newSelection);
-
   if (dispatchBeforeInputInsertText(
           eventTargetNodeForDocument(frame().document()), transposed,
-          InputEvent::InputType::InsertTranspose) !=
+          InputEvent::InputType::InsertTranspose,
+          new StaticRangeVector(1, StaticRange::create(range))) !=
       DispatchEventResult::NotCanceled)
     return;
 
   // 'beforeinput' event handler may destroy document.
   if (m_frame->document()->frame() != m_frame)
     return;
 
   // TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited. see http://crbug.com/590369 for more details.
   frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
+  // 'beforeinput' event handler may change selection, we need to re-calculate
+  // range.
+  range = getTransposeRange(frame());
+  if (range.isNull())
+    return;
+
+  text = plainText(range);

[yosin_UTC9, 2017/04/06 04:32:23]

Could you introduce new variable to avoid re-using |text|?

[chongz, 2017/04/07 02:29:22]

Done.

+  if (text.length() != 2)
+    return;
+  transposed = text.right(1) + text.left(1);

[yosin_UTC9, 2017/04/06 04:32:24]

Could you introduce new variable?

[chongz, 2017/04/07 02:29:22]

Done.

+
+  const SelectionInDOMTree newSelection =

[yosin_UTC9, 2017/04/06 04:32:24]

nit: s/const SelectionInDOMTree/const SelectionInDOMTree&/

[chongz, 2017/04/07 02:29:22]

Done.

+      SelectionInDOMTree::Builder().setBaseAndExtent(range).build();
+
+  // Select the two characters.
+  if (createVisibleSelection(newSelection) !=
+      frame().selection().computeVisibleSelectionInDOMTree())
+    frame().selection().setSelection(newSelection);
+
   // Insert the transposed characters.
   replaceSelectionWithText(transposed, false, false,
                            InputEvent::InputType::InsertTranspose);
 }
 
 void Editor::addToKillRing(const EphemeralRange& range) {
   if (m_shouldStartNewKillRingSequence)
     killRing().startNewSequence();
 
   DCHECK(!frame().document()->needsLayoutTreeUpdate());
@@ skipping 356 matching lines @@
 
 DEFINE_TRACE(Editor) {
   visitor->trace(m_frame);
   visitor->trace(m_lastEditCommand);
   visitor->trace(m_undoStack);
   visitor->trace(m_mark);
   visitor->trace(m_typingStyle);
 }
 
 }  // namespace blink