Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2779763004: Create ServiceWorkerProviderHost before starting worker (Closed)
Patch Set: Addressed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index ef267112f83f15932416276a09f650c3d7924f25..9e0755b53e308e547d58210c70680057bbab4db0 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -304,6 +304,10 @@ class CONTENT_EXPORT ServiceWorkerVersion
return controllee_map_;
}
+ // The provider host hosting this version. Only valid while the version is
+ // running.
+ ServiceWorkerProviderHost* provider_host() { return provider_host_.get(); }
+
base::WeakPtr<ServiceWorkerContextCore> context() const { return context_; }
// Adds and removes |request_job| as a dependent job not to stop the
@@ -556,6 +560,7 @@ class CONTENT_EXPORT ServiceWorkerVersion
// EmbeddedWorkerInstance::Listener overrides:
void OnThreadStarted() override;
void OnStarting() override;
+ void OnStartWorkerMessageSent() override;
void OnStarted() override;
void OnStopping() override;
void OnStopped(EmbeddedWorkerStatus old_status) override;
@@ -733,6 +738,15 @@ class CONTENT_EXPORT ServiceWorkerVersion
std::set<const ServiceWorkerURLRequestJob*> streaming_url_request_jobs_;
+ // Keeps track of the provider hosting worker's context for this version.
falken 2017/06/14 08:10:35 "hosting this running service worker"
shimazu 2017/06/16 04:18:44 Done.
+ // |pending_provider_host_| is valid from StartWorkerInternal to
+ // OnStartWorkerMessageSent. On OnStartWorkerMessageSent, the ownership will
+ // be passed to ServiceWorkerContextCore.
+ // |provider_host_| is always valid as long as this version has
+ // the running context.
+ std::unique_ptr<ServiceWorkerProviderHost> pending_provider_host_;
+ base::WeakPtr<ServiceWorkerProviderHost> provider_host_;
+
std::map<std::string, ServiceWorkerProviderHost*> controllee_map_;
// Will be null while shutting down.
base::WeakPtr<ServiceWorkerContextCore> context_;

Powered by Google App Engine
This is Rietveld 408576698