Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 2779763004: Create ServiceWorkerProviderHost before starting worker (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration_unittest.cc
diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc
index 490f6ecaa2d366875611b5340f406115a332379d..7d943cd379f22809f0ca618001a3a80f46297374 100644
--- a/content/browser/service_worker/service_worker_registration_unittest.cc
+++ b/content/browser/service_worker/service_worker_registration_unittest.cc
@@ -94,7 +94,7 @@ class ServiceWorkerRegistrationTest : public testing::Test {
ServiceWorkerRegistrationInfo observed_info_;
};
- private:
+ protected:
std::unique_ptr<EmbeddedWorkerTestHelper> helper_;
TestBrowserThreadBundle thread_bundle_;
};
@@ -257,9 +257,11 @@ class ServiceWorkerActivationTest : public ServiceWorkerRegistrationTest {
// Give the active version a controllee.
host_ = CreateProviderHostForWindow(
- 33 /* dummy render process id */, 1 /* dummy provider_id */,
+ helper_->mock_render_process_id(), 1 /* dummy provider_id */,
true /* is_parent_frame_secure */, context()->AsWeakPtr(),
&remote_endpoint_);
+ DCHECK(remote_endpoint_.client_request()->is_pending());
+ DCHECK(remote_endpoint_.host_ptr()->is_bound());
version_1->AddControllee(host_.get());
// Give the active version an in-flight request.

Powered by Google App Engine
This is Rietveld 408576698