Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2779703003: When linking natives lazily (as in AOT compilation), don't resolve them eagerly. (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When linking natives lazily (as in AOT compilation), don't resolve them eagerly. Avoids requiring an embedder to setup native stubs for functions that aren't called just to run Dart_Precompile. Issue #24686 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/8df8025f2acb09c55e8c22ba22826f03cbf497cb

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M runtime/vm/intermediate_language.cc View 1 2 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rmacnak
3 years, 8 months ago (2017-03-28 21:45:20 UTC) #3
Florian Schneider
Lgtm. I'd add a few lines from the issue to the CL description.
3 years, 8 months ago (2017-03-28 22:07:56 UTC) #4
rmacnak
On 2017/03/28 22:07:56, Florian Schneider wrote: > Lgtm. > > I'd add a few lines ...
3 years, 8 months ago (2017-03-28 22:29:06 UTC) #6
rmacnak
3 years, 8 months ago (2017-03-28 22:29:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
8df8025f2acb09c55e8c22ba22826f03cbf497cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698