Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5584)

Unified Diff: chromecast/app/BUILD.gn

Issue 2779663003: [Chromecast] Require chromecast OWNERS to be aware of locale changes. (Closed)
Patch Set: Updated GN comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/app/verify_cast_locales.py » ('j') | chromecast/app/verify_cast_locales.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/app/BUILD.gn
diff --git a/chromecast/app/BUILD.gn b/chromecast/app/BUILD.gn
index edf362369acd4cb2dbbac9addf4192aed7750b20..c2e4b26b2ee18a34ee07ac4fe4a9f309425096a5 100644
--- a/chromecast/app/BUILD.gn
+++ b/chromecast/app/BUILD.gn
@@ -112,4 +112,30 @@ grit("chromecast_settings") {
foreach(locale, locales_with_fake_bidi) {
outputs += [ "chromecast_settings_${locale}.pak" ]
}
+
+ deps = [
+ ":verify_cast_locales",
+ ]
+}
+
+# This target ensures that Chromecast developers are notified when locales
+# change. If this target is breaking the build, the CAST_LOCALES list in
+# //chromecast/app/verify_cast_locales.py must be updated to match
+# |locales_with_fake_bidi|. Please see that file for more details. This action
+# will be run on fresh builds, and whenever |locales_with_fake_bidi| is updated.
+action("verify_cast_locales") {
+ script = "//chromecast/app/verify_cast_locales.py"
+
+ # This file will be touched on success, preventing an unecessary rebuild.
Nico 2017/03/30 15:31:47 typo unecessary. These files are usually called "s
slan 2017/03/30 15:49:01 Done. Comments and arg updated.
+ touch_file = "$target_gen_dir/cast_locales_verified"
+ args = [
+ "-t",
+ rebase_path(touch_file, "$root_out_dir"),
+ ]
+
+ args += locales_with_fake_bidi
+
+ outputs = [
+ touch_file,
+ ]
}
« no previous file with comments | « no previous file | chromecast/app/verify_cast_locales.py » ('j') | chromecast/app/verify_cast_locales.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698