Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: chromecast/app/BUILD.gn

Issue 2779663003: [Chromecast] Require chromecast OWNERS to be aware of locale changes. (Closed)
Patch Set: Address feedback from thakis@ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chromecast/app/verify_cast_locales.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/locales.gni") 5 import("//build/config/locales.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 import("//tools/grit/grit_rule.gni") 7 import("//tools/grit/grit_rule.gni")
8 8
9 source_set("app") { 9 source_set("app") {
10 sources = [ 10 sources = [
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 grit("chromecast_settings") { 105 grit("chromecast_settings") {
106 source = "//chromecast/app/resources/chromecast_settings.grd" 106 source = "//chromecast/app/resources/chromecast_settings.grd"
107 resource_ids = "//chromecast/app/resources/resource_ids" 107 resource_ids = "//chromecast/app/resources/resource_ids"
108 108
109 outputs = [ 109 outputs = [
110 "grit/chromecast_settings.h", 110 "grit/chromecast_settings.h",
111 ] 111 ]
112 foreach(locale, locales_with_fake_bidi) { 112 foreach(locale, locales_with_fake_bidi) {
113 outputs += [ "chromecast_settings_${locale}.pak" ] 113 outputs += [ "chromecast_settings_${locale}.pak" ]
114 } 114 }
115
116 deps = [
117 ":verify_cast_locales",
118 ]
115 } 119 }
120
121 # This target ensures that Chromecast developers are notified when locales
122 # change. If this target is breaking the build, the CAST_LOCALES list in
123 # //chromecast/app/verify_cast_locales.py must be updated to match
124 # |locales_with_fake_bidi|. Please see that file for more details. This action
125 # will be run on fresh builds, and whenever |locales_with_fake_bidi| is updated.
126 action("verify_cast_locales") {
127 script = "//chromecast/app/verify_cast_locales.py"
128
129 # This file will be stamped on success, preventing an unnecessary rebuild.
130 stamp_file = "$target_gen_dir/cast_locales_verified"
131 args = [
132 "-s",
133 rebase_path(stamp_file, "$root_out_dir"),
134 ]
135
136 args += locales_with_fake_bidi
137
138 outputs = [
139 stamp_file,
140 ]
141 }
OLDNEW
« no previous file with comments | « no previous file | chromecast/app/verify_cast_locales.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698