Add UMA histograms for DirectComposition overlays.

gpu/ipc/service/direct_composition_surface_win.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/ipc/service/direct_composition_surface_win.h"
 
 #include <d3d11_1.h>
 #include <dcomptypes.h>
 
 #include "base/memory/ptr_util.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/optional.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/trace_event/trace_event.h"
 #include "base/win/scoped_handle.h"
 #include "gpu/ipc/service/gpu_channel_manager.h"
 #include "gpu/ipc/service/gpu_channel_manager_delegate.h"
 #include "gpu/ipc/service/switches.h"
 #include "ui/display/display_switches.h"
 #include "ui/gfx/geometry/size_conversions.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 316 matching lines @@
 
     hr = video_context_->VideoProcessorBlt(video_processor_.get(),
                                            out_view_.get(), 0, 1, &stream);
     CHECK(SUCCEEDED(hr));
   }
 
   swap_chain_scale_x_ = bounds_rect.width() * 1.0f / swap_chain_size.width();
   swap_chain_scale_y_ = bounds_rect.height() * 1.0f / swap_chain_size.height();
 
   swap_chain_->Present(first_present ? 0 : 1, 0);
+
+  base::win::ScopedComPtr<IDXGISwapChainMedia> swap_chain_media;
+  if (SUCCEEDED(swap_chain_.QueryInterface(swap_chain_media.Receive()))) {
+    DXGI_FRAME_STATISTICS_MEDIA stats = {};
+    if (SUCCEEDED(swap_chain_media->GetFrameStatisticsMedia(&stats))) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "GPU.DirectComposition.CompositionMode", stats.CompositionMode,
+          DXGI_FRAME_PRESENTATION_MODE_COMPOSITION_FAILURE + 1);

[Ilya Sherman, 2017/03/29 05:16:42]

This code looks fragile, in the sense that someone who updates the enum won't
necessarily know to update this code.  Please add either a COUNT or a MAX entry
to the enum, and document that the enum is now being used to back an UMA
histogram, and should therefore be treated as append-only.

+    }
+  }
 }
 
 bool DCLayerTree::SwapChainPresenter::InitializeVideoProcessor(
     const gfx::Size& in_size,
     const gfx::Size& out_size) {
   if (video_processor_ && SizeContains(processor_input_size_, in_size) &&
       SizeContains(processor_output_size_, out_size))
     return false;
   processor_input_size_ = in_size;
   processor_output_size_ = out_size;
@@ skipping 191 matching lines @@
       visual_info->clip_visual->SetClip(clip.get());
     } else {
       visual_info->clip_visual->SetClip(nullptr);
     }
   }
 }
 
 bool DCLayerTree::CommitAndClearPendingOverlays() {
   TRACE_EVENT1("gpu", "DCLayerTree::CommitAndClearPendingOverlays", "size",
                pending_overlays_.size());
+  UMA_HISTOGRAM_BOOLEAN("GPU.DirectComposition.OverlaysUsed",
+                        !pending_overlays_.empty());
   // Add an overlay with z-order 0 representing the main plane.
   gfx::Size surface_size = surface_->GetSize();
   pending_overlays_.push_back(base::MakeUnique<ui::DCRendererLayerParams>(
       false, gfx::Rect(), 0, gfx::Transform(), nullptr,
       gfx::RectF(gfx::SizeF(surface_size)), gfx::Rect(surface_size), 0, 0, 1.0,
       0));
 
   // TODO(jbauman): Reuse swapchains that are switched between overlays and
   // underlays.
   std::sort(pending_overlays_.begin(), pending_overlays_.end(),
@@ skipping 404 matching lines @@
 gfx::Vector2d DirectCompositionSurfaceWin::GetDrawOffset() const {
   return draw_offset_;
 }
 
 scoped_refptr<base::TaskRunner>
 DirectCompositionSurfaceWin::GetWindowTaskRunnerForTesting() {
   return child_window_.GetTaskRunnerForTesting();
 }
 
 }  // namespace gpu